-
Notifications
You must be signed in to change notification settings - Fork 951
[azidentity] Allow Identity Binding mode to be set via configuration options #25664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution @zarvd! We will review the pull request and get back to you soon. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request allows the Azure Identity Binding mode configuration to be set via explicit options rather than just environment variables. The PR adds:
- A new
GetFederatedTokenfunction option to provide custom token retrieval logic - A new
AzureProxyfield inWorkloadIdentityCredentialOptionsto configure proxy settings explicitly - Refactoring of internal configuration logic to separate environment variable reading from configuration application
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/azidentity/workload_identity.go |
Adds GetFederatedToken and AzureProxy options to allow programmatic configuration instead of only environment variables |
sdk/azidentity/workload_identity_test.go |
Adds tests for the new override functionality for federated tokens and Azure proxy configuration |
sdk/azidentity/internal/customtokenproxy/configuration.go |
New file extracting configuration logic into a reusable Options struct with an Apply function |
sdk/azidentity/internal/customtokenproxy/configuration_test.go |
Comprehensive tests for the new configuration API |
sdk/azidentity/internal/customtokenproxy/transport.go |
Removes configuration logic moved to configuration.go |
sdk/azidentity/internal/customtokenproxy/transport_test.go |
Removes tests moved to configuration_test.go, adds minor whitespace cleanup |
sdk/azidentity/go.work.sum |
Updated Go workspace dependencies |
enj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
3ca05c4 to
06c9eb3
Compare
| // The proxy feature is designed for applications that deploy to many clusters and clusters that host many | ||
| // applications. See the Azure Kubernetes Service identity bindings documentation for more information on when | ||
| // to set this option: https://learn.microsoft.com/azure/aks/identity-bindings-concepts | ||
| EnableAzureProxy bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@microsoft-github-policy-service agree company="Microsoft" |
fix #25663