Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Dec 3, 2025

Copilot AI review requested due to automatic review settings December 3, 2025 05:46
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 3, 2025
Copilot finished reviewing on behalf of jliusan December 3, 2025 05:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR regenerates the Azure Quota SDK based on the latest TypeSpec definitions. The primary change is the migration from the versioned module path (armquota/v2) to an unversioned path (armquota), along with updates to the underlying TypeSpec source location and emitter version.

Key changes include:

  • Migration from module version v2 to unversioned module
  • Update to TypeSpec emitter from version 0.8.2 to 0.8.6
  • Update of TypeSpec source location from specification/quota/Quota.Management to specification/quota/resource-manager/Microsoft.Quota/Quota
  • Addition of parameter validation checks for empty scope parameters
  • Improved documentation comments for client constructors
  • Import reorganization in several files
  • Addition of new operation client examples

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
go.mod Updates module path from v2 to unversioned; adds problematic self-dependency
go.sum Updates dependency checksums; includes entries for self-dependency
tsp-location.yaml Updates TypeSpec source directory and commit reference
testdata/_metadata.json Updates emitter version from 0.8.2 to 0.8.6
*_client.go (multiple) Updates import paths, adds scope validation, improves documentation; contains variable capitalization bugs
*_client_example_test.go (multiple) Updates import paths from v2 to unversioned; contains incorrect example calls
fake/*_server.go (multiple) Updates import paths from v2 to unversioned
operation_client_example_test.go New file with comprehensive operation examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants