Skip to content

[azcore] move time parsing to core #25714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
gracewilcox wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[azcore] move time parsing to core #25714

gracewilcox wants to merge 1 commit into from

Conversation

@gracewilcox
Copy link
Member

@gracewilcox gracewilcox commented Dec 3, 2025

Part of #22314

Moving time to core. Will be consumed by generator.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/azcore

jhendrixMSFT
jhendrixMSFT reviewed Dec 4, 2025
View reviewed changes
sdk/azcore/datetime/RFC3339.go
dateTimeJSONNoT = `"` + dateTimeNoT + `"`
)

type DateTimeRFC3339 time.Time
Copy link
Member

@jhendrixMSFT jhendrixMSFT Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove DateTime prefix.

Copy link
Member

@jhendrixMSFT jhendrixMSFT Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also will need docs.

jhendrixMSFT
jhendrixMSFT reviewed Dec 4, 2025
View reviewed changes
sdk/azcore/datetime/date_type.go
jsonFormat = `%04d-%02d-%02d`
)

type DateType time.Time
Copy link
Member

@jhendrixMSFT jhendrixMSFT Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type PlainDate time.Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT left review comments

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter will be requested when the pull request is marked ready for review RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell will be requested when the pull request is marked ready for review chlowell is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft will be requested when the pull request is marked ready for review richardpark-msft is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Azure.Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gracewilcox @jhendrixMSFT