Fix audience URLs for AzureGovernment and AzureChina to align with Azure CLI #25715
Conversation
AzureMarker
requested review from
RickWinter,
chlowell,
jhendrixMSFT and
richardpark-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes audience URL inconsistencies for AzureGovernment and AzureChina cloud configurations by adding trailing slashes to align with Azure CLI, other SDKs, and the existing AzurePublic configuration.
Key Changes:
- Added trailing slashes to
cloud.AzureChinaandcloud.AzureGovernmentaudience URLs - Updated CHANGELOG.md to document the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/azcore/arm/runtime/runtime.go | Added trailing slashes to audience URLs for AzureChina and AzureGovernment to match AzurePublic and align with Azure CLI |
| sdk/azcore/CHANGELOG.md | Added entry documenting the bug fix for audience values in version 1.20.1 |
Review Summary: No issues found. The changes correctly fix the audience URL inconsistency by adding trailing slashes to AzureChina and AzureGovernment configurations, making them consistent with the existing AzurePublic configuration. The existing test coverage in pipeline_test.go validates these audience URLs and will continue to work correctly with the trailing slashes, as the test constructs scopes by appending "/.default" to the audience URL.
# Conflicts: # sdk/azcore/CHANGELOG.md
|
|
||
| ### Bugs Fixed | ||
|
|
||
| * Fixed `cloud.AzureGovernment` and `cloud.AzureChina` audience values so they align with Azure CLI and other SDKs. |
There was a problem hiding this comment.
Can you please move this to the Other Changes section.
2 participants
This PR fixes #25700