[Migrate-Check-TypeSpec-Mitigate]sdk/resourcemanager/resourcegraph/armresourcegraph # by jliusan · Pull Request #26345 · Azure/azure-sdk-for-go

jliusan · 2026-03-20T02:47:48Z

based on branch:ruih/resourcegraph-tsp-convert

jliusan · 2026-03-20T02:48:36Z

sdk/resourcemanager/resourcegraph/armresourcegraph/CHANGELOG.md

+- Struct `ErrorResponse` has been removed
+- Struct `Table` has been removed
+- Field `Interface` of struct `ClientResourcesHistoryResponse` has been removed
+


New Breaking changes:

Enum ColumnDataType has been removed

Struct Column has been removed

Struct Error has been removed

Struct ErrorResponse has been removed

Struct Table has been removed

removed breaking changes:

Function NewClientFactory parameter(s) have been changed from (credential azcore.TokenCredential, options *arm.ClientOptions) to (subscriptionID string, credential azcore.TokenCredential, options *arm.ClientOptions)

jliusan · 2026-03-20T02:50:18Z

sdk/resourcemanager/resourcegraph/armresourcegraph/CHANGELOG.md

+- Field `Interface` of struct `ClientResourcesHistoryResponse` has been removed
+
+### Features Added
+


New Features Added:

New function *Client.NewGraphQueryClient() *GraphQueryClient

New function *Client.NewOperationsClient() *OperationsClient

New function *ClientFactory.NewGraphQueryClient(subscriptionID string) *GraphQueryClient

New field NextLink in struct OperationListResult

Removed features added:

New function *ClientFactory.NewGraphQueryClient() *GraphQueryClient

New struct ErrorFieldContract

New struct GraphQueryError

New struct GraphQueryErrorError

New struct Resource

New struct ResourceSnapshotData

Copilot

Pull request overview

This PR migrates sdk/resourcemanager/resourcegraph/armresourcegraph from the older AutoRest-generated shape to the newer TypeSpec/Go Code Generator output, updating clients, models, fakes, and module metadata accordingly.

Changes:

Adds new Graph Query client surface (client + fakes) and resource change APIs, and updates paging behavior.
Regenerates models/serde and response/option types to match the newer API versions and generator patterns.
Updates module metadata/dependencies (version.go, go.mod/go.sum, tsp-location.yaml) and removes legacy AutoRest artifacts.

Reviewed changes

Copilot reviewed 28 out of 29 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
sdk/resourcemanager/resourcegraph/armresourcegraph/version.go	Adds generated module name/version constants.
sdk/resourcemanager/resourcegraph/armresourcegraph/tsp-location.yaml	Adds TypeSpec source metadata for regeneration.
sdk/resourcemanager/resourcegraph/armresourcegraph/time_rfc3339.go	Removes legacy custom RFC3339 time handling helper.
sdk/resourcemanager/resourcegraph/armresourcegraph/testdata/_metadata.json	Adds generator/test metadata (apiVersions/emitterVersion).
sdk/resourcemanager/resourcegraph/armresourcegraph/responses.go	Introduces updated response wrapper types for new methods/clients.
sdk/resourcemanager/resourcegraph/armresourcegraph/response_types.go	Removes legacy response types file.
sdk/resourcemanager/resourcegraph/armresourcegraph/polymorphic_helpers.go	Updates null-handling for polymorphic unmarshal helpers.
sdk/resourcemanager/resourcegraph/armresourcegraph/options.go	Adds new options types for newly introduced operations.
sdk/resourcemanager/resourcegraph/armresourcegraph/operations_client.go	Updates Operations client API version + paging implementation.
sdk/resourcemanager/resourcegraph/armresourcegraph/models_serde.go	Updates model JSON serde; adds time helpers using azcore datetime types.
sdk/resourcemanager/resourcegraph/armresourcegraph/models.go	Updates model types to the new spec (GraphQuery/resource changes/systemData).
sdk/resourcemanager/resourcegraph/armresourcegraph/interfaces.go	Updates generator header and interface file baseline.
sdk/resourcemanager/resourcegraph/armresourcegraph/graphquery_client.go	Adds new `GraphQueryClient` implementation.
sdk/resourcemanager/resourcegraph/armresourcegraph/go.mod	Updates azcore and indirect dependencies.
sdk/resourcemanager/resourcegraph/armresourcegraph/go.sum	Updates checksums for bumped dependencies.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/time_rfc3339.go	Removes legacy fake time helper.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/server_factory.go	Extends fake server factory routing for new clients.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/server.go	Adds fakes for new methods and dispatch for additional clients.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/operations_server.go	Updates pager fake to support NextLink injection and interception.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/internal.go	Adds shared helper types (result/initServer) used by fake transports.
sdk/resourcemanager/resourcegraph/armresourcegraph/fake/graphquery_server.go	Adds GraphQuery client fake server + transport implementation.
sdk/resourcemanager/resourcegraph/armresourcegraph/constants.go	Updates enums/constants to new spec surface.
sdk/resourcemanager/resourcegraph/armresourcegraph/client_factory.go	Refactors factory to share an internal arm.Client and expose GraphQuery client creation.
sdk/resourcemanager/resourcegraph/armresourcegraph/client_example_test.go	Updates generated examples to new operations and shapes.
sdk/resourcemanager/resourcegraph/armresourcegraph/client.go	Adds resource change operations and helper constructors; updates API versions.
sdk/resourcemanager/resourcegraph/armresourcegraph/build.go	Removes legacy go:generate entrypoint for AutoRest flow.
sdk/resourcemanager/resourcegraph/armresourcegraph/autorest.md	Removes AutoRest configuration file.
sdk/resourcemanager/resourcegraph/armresourcegraph/README.md	Updates factory usage and client creation examples.
sdk/resourcemanager/resourcegraph/armresourcegraph/CHANGELOG.md	Adds 0.10.0 entry describing breaking changes and new features.

Copilot · 2026-03-20T02:51:34Z

sdk/resourcemanager/resourcegraph/armresourcegraph/client.go

+func (client *Client) NewGraphQueryClient() *GraphQueryClient {
+	return &GraphQueryClient{
+		internal: client.internal,


Client.NewGraphQueryClient() returns a GraphQueryClient without setting subscriptionID, but all GraphQuery operations require a subscription ID and will error with "parameter client.subscriptionID cannot be empty". Consider changing this constructor to accept a subscriptionID parameter (and set the field), or remove it in favor of NewGraphQueryClient(subscriptionID, credential, options) / ClientFactory.NewGraphQueryClient(subscriptionID).

Suggested change

func (client *Client) NewGraphQueryClient() *GraphQueryClient {

return &GraphQueryClient{

internal: client.internal,

func (client *Client) NewGraphQueryClient(subscriptionID string) *GraphQueryClient {

return &GraphQueryClient{

internal: client.internal,

subscriptionID: subscriptionID,

Copilot · 2026-03-20T02:51:34Z

sdk/resourcemanager/resourcegraph/armresourcegraph/README.md


 ```go
-client := clientFactory.NewClient()
+client := clientFactory.NewGraphQueryClient()


The README example calls clientFactory.NewGraphQueryClient() with no arguments, but ClientFactory.NewGraphQueryClient now requires a subscriptionID parameter. Update the example to pass a subscription ID (or to use the supported constructor pattern if NewGraphQueryClient is changed).

Suggested change

client := clientFactory.NewGraphQueryClient()

subscriptionID := "00000000-0000-0000-0000-000000000000"

client := clientFactory.NewGraphQueryClient(subscriptionID)

Copilot · 2026-03-20T02:51:35Z

sdk/resourcemanager/resourcegraph/armresourcegraph/tsp-location.yaml

@@ -0,0 +1,4 @@
+directory: specification/resourcegraph/resource-manager/Microsoft.ResourceGraph/ResourceGraph
+commit: 5eed3b9a301906268af21bbe256898387661ed42
+repo: i-specs


tsp-location.yaml uses repo: i-specs, but other ARM TypeSpec modules in this repo use repo: Azure/azure-rest-api-specs (e.g., sdk/resourcemanager/resources/armbicep/tsp-location.yaml). Please update this to the standard repo value so tooling can resolve the spec location consistently.

Suggested change

repo: i-specs

repo: Azure/azure-rest-api-specs

Copilot · 2026-03-20T02:51:35Z

sdk/resourcemanager/resourcegraph/armresourcegraph/client_example_test.go

-	// 			"location": "westus",
-	// 			"tags":map[string]any{
+	// res = armresourcegraph.ClientResourceChangeDetailsResponse{
+	// 	undefined: &[]*armresourcegraph.ResourceChangeData{


The example response snippet is incorrect: ClientResourceChangeDetailsResponse doesn't have a field named undefined (it should be ResourceChangeDataArray). This makes the generated example misleading; please update the commented response to use the actual response struct field names.

Suggested change

// undefined: &[]*armresourcegraph.ResourceChangeData{

// ResourceChangeDataArray: []*armresourcegraph.ResourceChangeData{

Copilot · 2026-03-20T02:51:35Z

sdk/resourcemanager/resourcegraph/armresourcegraph/client_example_test.go

+	// res = armresourcegraph.ClientResourceChangesResponse{
+	// 	ResourceChangeList: &armresourcegraph.ResourceChangeList{
+	// 		Changes: []*armresourcegraph.ResourceChangeData{
+	// 			{


The example response snippet uses ResourceChangeList: &armresourcegraph.ResourceChangeList{...}, but ClientResourceChangesResponse embeds ResourceChangeList (non-pointer). Update the commented example to use the correct composite literal shape (and field name), otherwise the snippet can't be used as a reference.

Copilot · 2026-03-20T02:51:35Z

sdk/resourcemanager/resourcegraph/armresourcegraph/constants.go

@@ -87,12 +149,47 @@ func PossibleResultFormatValues() []ResultFormat {
 	}
 }

+// ResultFormat - Defines in which format query result returned.
+type ResultFormat string
+
+const (
+	// ResultFormatObjectArray - objectArray
+	ResultFormatObjectArray ResultFormat = "objectArray"
+	// ResultFormatTable - table
+	ResultFormatTable ResultFormat = "table"
+)
+
+// PossibleResultFormatValues returns the possible values for the ResultFormat const type.
+func PossibleResultFormatValues() []ResultFormat {
+	return []ResultFormat{
+		ResultFormatObjectArray,
+		ResultFormatTable,
+	}
+}


ResultFormat (type, consts, and PossibleResultFormatValues) is declared twice in this file, which will cause a compile-time redeclaration error. Remove the duplicate block so ResultFormat is defined only once.

github-actions · 2026-03-20T02:56:50Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/resourcegraph/armresourcegraph

add code

61f1244

jliusan requested review from JiaqiZhang-Dev, lirenhe and tadelesh as code owners March 20, 2026 02:47

Copilot AI review requested due to automatic review settings March 20, 2026 02:47

github-actions bot added the Mgmt This issue is related to a management-plane library. label Mar 20, 2026

jliusan commented Mar 20, 2026

View reviewed changes

Copilot started reviewing on behalf of jliusan March 20, 2026 02:49 View session

jliusan commented Mar 20, 2026

View reviewed changes

Copilot AI reviewed Mar 20, 2026

View reviewed changes

jliusan closed this Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Migrate-Check-TypeSpec-Mitigate]sdk/resourcemanager/resourcegraph/armresourcegraph ##26345

[Migrate-Check-TypeSpec-Mitigate]sdk/resourcemanager/resourcegraph/armresourcegraph ##26345
jliusan wants to merge 1 commit intomainfrom
mitigate-resourcegraph-mg2

jliusan commented Mar 20, 2026

Uh oh!

jliusan Mar 20, 2026 •

edited

Loading

Uh oh!

jliusan Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		- Field `Interface` of struct `ClientResourcesHistoryResponse` has been removed

		### Features Added

	client := clientFactory.NewGraphQueryClient()
	subscriptionID := "00000000-0000-0000-0000-000000000000"
	client := clientFactory.NewGraphQueryClient(subscriptionID)

	// undefined: &[]*armresourcegraph.ResourceChangeData{
	// ResourceChangeDataArray: []*armresourcegraph.ResourceChangeData{

Conversation

jliusan commented Mar 20, 2026

Uh oh!

jliusan Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jliusan Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 20, 2026

API Change Check

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jliusan Mar 20, 2026 •

edited

Loading