[AutoPR sdk-security/keyvault/azcertificates]-generated-from-SDK Generation - Go-6045571#26353
[AutoPR sdk-security/keyvault/azcertificates]-generated-from-SDK Generation - Go-6045571#26353
Conversation
…nfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045571 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…s and update test recordings
There was a problem hiding this comment.
Pull request overview
Regenerates the azcertificates Key Vault certificates data-plane SDK from the TypeSpec configuration targeting API version 2025-07-01 (stable), updating generated serialization logic, dependencies, and tests to reflect newly added SAN fields.
Changes:
- Updates TypeSpec source location metadata and module assets tag for the new generation input.
- Reworks time serialization to use
azcore/runtime/datetimetypes (removing the localtime_unix.gohelper). - Adds/extends tests and refreshes dependency versions and generator metadata.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/security/keyvault/azcertificates/tsp-location.yaml | Updates spec directory/commit and additionalDirectories for TypeSpec input. |
| sdk/security/keyvault/azcertificates/models_serde.go | Switches unix-time serde to runtime/datetime generic helpers. |
| sdk/security/keyvault/azcertificates/client_test.go | Adds tests covering SAN serde and fake-server round-trips for new SAN fields. |
| sdk/security/keyvault/azcertificates/go.mod | Bumps azcore and indirect golang.org/x/* dependencies. |
| sdk/security/keyvault/azcertificates/go.sum | Updates sums for bumped dependencies. |
| sdk/security/keyvault/azcertificates/testdata/_metadata.json | Updates generator metadata format and emitter version. |
| sdk/security/keyvault/azcertificates/assets.json | Updates the assets tag for this generation. |
| sdk/security/keyvault/azcertificates/CHANGELOG.md | Finalizes 1.5.0 entry and summarizes new SAN fields. |
| sdk/security/keyvault/azcertificates/time_unix.go | Removes local Unix timestamp serde helper (replaced by datetime.Unix). |
| sdk/security/keyvault/azcertificates/build.go | Removes prior build/go-generate stub. |
| additionalDirectories: | ||
| - specification/keyvault/Security.KeyVault.Common | ||
| - specification/keyvault/data-plane/Certificates/common |
There was a problem hiding this comment.
additionalDirectories is currently parsed as null because the list item on the next line isn’t indented under the key. This makes the YAML structure incorrect for tools that read tsp-location.yaml. Indent the list item(s) under additionalDirectories: (and consider removing the trailing space after the colon).
| ## 1.5.0 (2026-03-22) | ||
| ### Features Added | ||
| * Added support for IP addresses and URIs in `SubjectAlternativeNames` through new `IPAddresses` and `URIs` fields | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
| - New field `IPAddresses`, `URIs` in struct `SubjectAlternativeNames` | ||
|
|
There was a problem hiding this comment.
The 1.5.0 entry no longer mentions the API/service version bump to 2025-07-01 that this generation PR is based on, even though prior entries consistently call out service version upgrades in the changelog. Please add an Other Changes (or similar) bullet noting the service/API version upgrade so the release notes remain complete and consistent.
Configurations: 'specification/keyvault/data-plane/Certificates/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045571 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.