Skip to content

[AutoPR sdk-security/keyvault/azcertificates]-generated-from-SDK Generation - Go-6045571#26353

Open
azure-sdk wants to merge 4 commits intomainfrom
sdkauto/sdk-security-keyvault/azcertificates-6045571
Open

[AutoPR sdk-security/keyvault/azcertificates]-generated-from-SDK Generation - Go-6045571#26353
azure-sdk wants to merge 4 commits intomainfrom
sdkauto/sdk-security-keyvault/azcertificates-6045571

Conversation

@azure-sdk
Copy link
Collaborator

Configurations: 'specification/keyvault/data-plane/Certificates/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045571 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…nfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '06d1c57f16f9da0b2672c34e2066aa0a35b6e62c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6045571 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@rohitsinghal4u rohitsinghal4u marked this pull request as ready for review March 23, 2026 16:49
@rohitsinghal4u rohitsinghal4u requested a review from a team as a code owner March 23, 2026 16:49
Copilot AI review requested due to automatic review settings March 23, 2026 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the azcertificates Key Vault certificates data-plane SDK from the TypeSpec configuration targeting API version 2025-07-01 (stable), updating generated serialization logic, dependencies, and tests to reflect newly added SAN fields.

Changes:

  • Updates TypeSpec source location metadata and module assets tag for the new generation input.
  • Reworks time serialization to use azcore/runtime/datetime types (removing the local time_unix.go helper).
  • Adds/extends tests and refreshes dependency versions and generator metadata.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/security/keyvault/azcertificates/tsp-location.yaml Updates spec directory/commit and additionalDirectories for TypeSpec input.
sdk/security/keyvault/azcertificates/models_serde.go Switches unix-time serde to runtime/datetime generic helpers.
sdk/security/keyvault/azcertificates/client_test.go Adds tests covering SAN serde and fake-server round-trips for new SAN fields.
sdk/security/keyvault/azcertificates/go.mod Bumps azcore and indirect golang.org/x/* dependencies.
sdk/security/keyvault/azcertificates/go.sum Updates sums for bumped dependencies.
sdk/security/keyvault/azcertificates/testdata/_metadata.json Updates generator metadata format and emitter version.
sdk/security/keyvault/azcertificates/assets.json Updates the assets tag for this generation.
sdk/security/keyvault/azcertificates/CHANGELOG.md Finalizes 1.5.0 entry and summarizes new SAN fields.
sdk/security/keyvault/azcertificates/time_unix.go Removes local Unix timestamp serde helper (replaced by datetime.Unix).
sdk/security/keyvault/azcertificates/build.go Removes prior build/go-generate stub.

Comment on lines +4 to +5
additionalDirectories:
- specification/keyvault/Security.KeyVault.Common
- specification/keyvault/data-plane/Certificates/common
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionalDirectories is currently parsed as null because the list item on the next line isn’t indented under the key. This makes the YAML structure incorrect for tools that read tsp-location.yaml. Indent the list item(s) under additionalDirectories: (and consider removing the trailing space after the colon).

Copilot uses AI. Check for mistakes.
Comment on lines +3 to 7
## 1.5.0 (2026-03-22)
### Features Added
* Added support for IP addresses and URIs in `SubjectAlternativeNames` through new `IPAddresses` and `URIs` fields

### Breaking Changes

### Bugs Fixed
- New field `IPAddresses`, `URIs` in struct `SubjectAlternativeNames`

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.5.0 entry no longer mentions the API/service version bump to 2025-07-01 that this generation PR is based on, even though prior entries consistently call out service version upgrades in the changelog. Please add an Other Changes (or similar) bullet noting the service/API version upgrade so the release notes remain complete and consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants