Skip to content

Commit edcf29d

Browse files
committed
Timeout tests are run only in Live test mode
1 parent 27aa57f commit edcf29d

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/implementation/http/HttpClientHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public HttpResponse execute(HttpRequest request, RequestOptions requestOptions)
7979
Context requestContext = Context.NONE;
8080
Timeout timeout = requestOptions.getTimeout();
8181
if (timeout != null && !timeout.read().isZero() && !timeout.read().isNegative()) {
82-
requestContext = requestContext.addData("azure-response-timeout", timeout.request());
82+
requestContext = requestContext.addData("azure-response-timeout", timeout.read());
8383
}
8484

8585
com.azure.core.http.HttpResponse azureResponse = this.httpPipeline.sendSync(azureRequest, requestContext);

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsAsyncTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package com.azure.ai.agents;
55

66
import com.azure.core.http.HttpClient;
7+
import com.azure.core.test.annotation.LiveOnly;
78
import com.azure.core.util.logging.ClientLogger;
89
import com.azure.core.util.logging.LogLevel;
910
import com.openai.core.JsonValue;
@@ -15,7 +16,6 @@
1516
import com.openai.models.conversations.Message;
1617
import com.openai.models.conversations.items.*;
1718
import com.openai.models.responses.EasyInputMessage;
18-
import org.junit.jupiter.api.Disabled;
1919
import org.junit.jupiter.params.ParameterizedTest;
2020
import org.junit.jupiter.params.provider.MethodSource;
2121
import org.junit.platform.commons.util.StringUtils;
@@ -137,13 +137,13 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
137137

138138
}
139139

140+
@LiveOnly
140141
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
141142
@MethodSource("com.azure.ai.agents.TestUtils#getTestParameters")
142143
public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) throws ExecutionException, InterruptedException {
143144
ConversationsAsyncClient client = getConversationsAsyncClient(httpClient, serviceVersion);
144145
RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
145146

146-
// creation - conversation
147147
assertThrows(Exception.class, () -> client.getConversationServiceAsync().create(requestOptions).get());
148148
}
149149
}

sdk/ai/azure-ai-agents/src/test/java/com/azure/ai/agents/ConversationsTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
package com.azure.ai.agents;
55

66
import com.azure.core.http.HttpClient;
7+
import com.azure.core.test.annotation.LiveOnly;
78
import com.openai.core.JsonValue;
89
import com.openai.core.RequestOptions;
910
import com.openai.core.Timeout;
1011
import com.openai.models.conversations.*;
1112
import com.openai.models.conversations.items.*;
1213
import com.openai.models.responses.EasyInputMessage;
13-
import org.junit.jupiter.api.Disabled;
1414
import org.junit.jupiter.params.ParameterizedTest;
1515
import org.junit.jupiter.params.provider.MethodSource;
1616
import org.junit.platform.commons.util.StringUtils;
@@ -120,13 +120,13 @@ public void basicItemCRUDOperations(HttpClient httpClient, AgentsServiceVersion
120120
assertEquals(conversationId, conversationWithDeletedItem.id());
121121
}
122122

123+
@LiveOnly
123124
@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
124125
@MethodSource("com.azure.ai.agents.TestUtils#getTestParameters")
125126
public void timeoutResponse(HttpClient httpClient, AgentsServiceVersion serviceVersion) {
126127
ConversationsClient client = getConversationsSyncClient(httpClient, serviceVersion);
127128

128129
RequestOptions requestOptions = RequestOptions.builder().timeout(Timeout.builder().read(Duration.ofMillis(10)).build()).build();
129-
// creation - conversation
130130
assertThrows(Exception.class, () -> client.getConversationService().create(requestOptions));
131131
}
132132
}

0 commit comments

Comments
 (0)