Skip to content

Exception type name missing #42241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Exception type name missing #42241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a2528f
Exception type name missing
trask Oct 9, 2024
4ca50dc
Update sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java…
trask Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,9 +768,7 @@ private void exportEvents(SpanData span, @Nullable String operationName, @Nullab
if (stacktrace != null && !shouldSuppress.test(span, event)) {
String exceptionLogged = span.getAttributes().get(AiSemanticAttributes.LOGGED_EXCEPTION);
if (!stacktrace.equals(exceptionLogged)) {
consumer.accept(createExceptionTelemetryItem(
event.getAttributes().get(SemanticAttributes.EXCEPTION_STACKTRACE), span, operationName,
sampleRate));
consumer.accept(createExceptionTelemetryItem(event, span, operationName, sampleRate));
}
}
}
Expand Down Expand Up @@ -801,7 +799,7 @@ private void exportEvents(SpanData span, @Nullable String operationName, @Nullab
}
}

private TelemetryItem createExceptionTelemetryItem(String errorStack, SpanData span, @Nullable String operationName,
private TelemetryItem createExceptionTelemetryItem(EventData event, SpanData span, @Nullable String operationName,
@Nullable Double sampleRate) {

ExceptionTelemetryBuilder telemetryBuilder = ExceptionTelemetryBuilder.create();
Expand All @@ -815,13 +813,15 @@ private TelemetryItem createExceptionTelemetryItem(String errorStack, SpanData s
} else {
setOperationName(telemetryBuilder, span.getAttributes());
}
setTime(telemetryBuilder, span.getEndEpochNanos());
setTime(telemetryBuilder, event.getEpochNanos());
setSampleRate(telemetryBuilder, sampleRate);

// TODO (trask) should this map the span attributes or the event attributes?
MAPPINGS.map(span.getAttributes(), telemetryBuilder);

// set exception-specific properties
setExceptions(errorStack, span.getAttributes(), telemetryBuilder);
String errorStack = event.getAttributes().get(SemanticAttributes.EXCEPTION_STACKTRACE);
setExceptions(errorStack, event.getAttributes(), telemetryBuilder);

return telemetryBuilder.build();
}
Expand Down