Skip to content

Conversation

jiminwen-msft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 19:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request regenerates the Azure Communication Chat SDK to incorporate changes from a newer swagger specification. The main purpose is to update the generated models to support new communication identifiers and properties.

Key changes include:

  • Added support for TeamsExtensionUserIdentifierModel as a new communication identifier type
  • Enhanced PhoneNumberIdentifierModel with isAnonymous and assertedId properties
  • Updated terminology from "AAD" to "Entra ID" in documentation

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
swagger/README.md Updated swagger specification reference to newer commit hash
PhoneNumberIdentifierModel.java Added isAnonymous and assertedId properties with corresponding getters/setters and JSON serialization
MicrosoftTeamsUserIdentifierModel.java Updated documentation to use "Entra ID" instead of "AAD"
CreateChatThreadOptions.java Minor documentation improvements for return value descriptions
CommunicationIdentifierModelKind.java Added TEAMS_EXTENSION_USER enum constant
CommunicationIdentifierModel.java Added teamsExtensionUser property with getter/setter and JSON serialization
pom.xml Version bump from 1.6.0 to 1.6.1
README.md Updated version reference in dependency example
CHANGELOG.md Added entry for version 1.6.1 describing the new features
version_client.txt Updated version tracking for the package
Comments suppressed due to low confidence (3)

sdk/communication/azure-communication-chat/src/main/java/com/azure/communication/chat/implementation/models/CommunicationIdentifierModel.java:54

  • The new teamsExtensionUser property lacks test coverage. Consider adding unit tests to verify the getter, setter, and JSON serialization/deserialization behavior for this new property.
    private TeamsExtensionUserIdentifierModel teamsExtensionUser;

sdk/communication/azure-communication-chat/src/main/java/com/azure/communication/chat/implementation/models/PhoneNumberIdentifierModel.java:28

  • The new isAnonymous property lacks test coverage. Consider adding unit tests to verify the getter, setter, and JSON serialization/deserialization behavior, including the default false behavior when missing.
    private Boolean isAnonymous;

sdk/communication/azure-communication-chat/src/main/java/com/azure/communication/chat/implementation/models/PhoneNumberIdentifierModel.java:34

  • The new assertedId property lacks test coverage. Consider adding unit tests to verify the getter, setter, and JSON serialization/deserialization behavior for this new property.
    private String assertedId;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant