Skip to content

Conversation

azure-sdk
Copy link
Collaborator

Configurations: 'specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml', API Version: 2025-06-01-preview, SDK Release Type: beta, and CommitSHA: '260ed6a52537921f53a18ffaf4020e3b4d510367' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5202593 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

….Management/tspconfig.yaml', API Version: 2025-06-01-preview, SDK Release Type: beta, and CommitSHA: '260ed6a52537921f53a18ffaf4020e3b4d510367' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5202593 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Aug 11, 2025
Copy link
Contributor

github-actions bot commented Aug 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-azurestackhci-vm

@v-hongli1 v-hongli1 marked this pull request as ready for review August 11, 2025 05:09
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 05:09
Copilot

This comment was marked as outdated.

@shraddhasun shraddhasun enabled auto-merge (squash) August 11, 2025 18:53
@v-hongli1 v-hongli1 requested a review from Copilot August 12, 2025 01:27
Copilot

This comment was marked as outdated.

@v-hongli1 v-hongli1 requested a review from Copilot August 12, 2025 02:27
Copilot

This comment was marked as outdated.

@shraddhasun
Copy link
Member

@v-hongli1 who will review this?

@weidongxu-microsoft
Copy link
Member

Hi @shraddhasun , these kind of AutoPR is for service SDK release. It would require approval from both SDK dev and service dev.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds SDK generated code for the Azure Resource Manager AzureStackHCI VM management client, introducing network-related resource implementations including NetworkSecurityGroup, NetworkInterface, MarketplaceGalleryImage, and LogicalNetwork management classes.

  • Generated implementation classes for network security groups, network interfaces, marketplace gallery images, and logical networks
  • Client implementation classes with full REST API support including CRUD operations and long-running operation (LRO) handling
  • Standard Azure SDK patterns with fluent APIs and pagination support

Reviewed Changes

Copilot reviewed 62 out of 392 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
NetworkSecurityGroupImpl.java Implementation wrapper for network security group resources
NetworkInterfacesImpl.java Manager implementation for network interface collections
NetworkInterfacesClientImpl.java REST client implementation for network interface operations
NetworkInterfaceImpl.java Implementation wrapper for individual network interface resources
MarketplaceGalleryImagesImpl.java Manager implementation for marketplace gallery image collections
MarketplaceGalleryImagesClientImpl.java REST client implementation for marketplace gallery image operations
MarketplaceGalleryImageImpl.java Implementation wrapper for marketplace gallery image resources
LogicalNetworksImpl.java Manager implementation for logical network collections

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@shraddhasun shraddhasun disabled auto-merge August 14, 2025 18:04
@shraddhasun
Copy link
Member

@XiaofeiCao thanks for approving! Do i need additional approvals before I can merge?

@weidongxu-microsoft weidongxu-microsoft merged commit e94f88d into Azure:main Aug 18, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants