Skip to content

Conversation

kushagraThapar
Copy link
Member

@kushagraThapar kushagraThapar commented Aug 11, 2025

@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 17:56
@kushagraThapar kushagraThapar requested review from kirankumarkolli and a team as code owners August 11, 2025 17:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds long emulator CI to Cosmos pipelines by introducing a new test group "long-emulator" and configuring appropriate test infrastructure. The change separates longer-running emulator tests from the standard emulator test suite to improve CI performance and organization.

  • Introduces "long-emulator" test group for longer-running tests that were previously in the "emulator" group
  • Adds CI pipeline configuration to run these tests separately with dedicated matrix entries
  • Updates test infrastructure to support the new test group categorization

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TransportClient.java Changes method visibility from protected to public for getGlobalEndpointManager()
SharedTransportClient.java Updates method visibility to public for getGlobalEndpointManager() override
RntbdTransportClient.java Updates method visibility to public for getGlobalEndpointManager() override
HttpTransportClient.java Updates method visibility to public for getGlobalEndpointManager() override
IncrementalChangeFeedProcessorTest.java (pkversion) Migrates test methods from "emulator" to "long-emulator" group
IncrementalChangeFeedProcessorTest.java (epkversion) Migrates one test method from "emulator" to "long-emulator" group
FullFidelityChangeFeedProcessorTest.java Migrates test methods from "emulator" to "long-emulator" group
TestSuiteBase.java (rx) Adds "long-emulator" group to BeforeSuite and AfterSuite annotations
ContainerCreateDeleteWithSameNameTest.java Migrates all test methods from "emulator" to "long-emulator" group
AadAuthorizationTests.java Migrates test methods from "emulator" to "long-emulator" group
ThroughputControlTests.java Migrates all test methods from "emulator" to "long-emulator" group
ReflectionUtils.java Removes setGlobalEndpointManager method as it's no longer needed
TestSuiteBase.java (implementation) Adds "long-emulator" group to BeforeSuite and AfterSuite annotations
NetworkFailureTest.java Migrates test methods from "emulator" to "long-emulator" group
RetryContextOnDiagnosticTest.java Migrates test methods and updates mock setup to use public API
long-emulator-testng.xml files Adds TestNG configuration files for the new long-emulator test group
cosmos-emulator-matrix.json Adds CI pipeline matrix entries for long-emulator tests

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kushagraThapar kushagraThapar merged commit df5f964 into Azure:main Aug 13, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants