adding enableSmbDirectoryLease property #46362
Conversation
gunjansingh-msft
requested review from
seanmcc-msft,
ibrandes,
kyleknap,
alzimmermsft and
browndav-msft
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| String testShareName = generateShareName(); | ||
| ShareServiceClient serviceClient = primaryFileServiceClient; | ||
| ShareClient shareClient = serviceClient.getShareClient(testShareName); |
There was a problem hiding this comment.
don't we new up a primaryShareClient in the setup method? can we use that instead of creating a new shareClient every time? my question applies to the other tests too
There was a problem hiding this comment.
this will be addressed before stg100 is merged in
| } finally { | ||
| shareClient.delete(); | ||
| } |
There was a problem hiding this comment.
why are we deleting the share here? does the automatic test cleanup not detect this share? same with the other tests as well
There was a problem hiding this comment.
The explicit shareClient.delete(); in the finally block ensures that the test-created share is always deleted, even if an assertion fails or an exception is thrown.
There was a problem hiding this comment.
The explicit shareClient.delete(); in the finally block ensures that the test-created share is always deleted, even if an assertion fails or an exception is thrown.
if the assertion fails or an exception is thrown, the test cleanup method kicks in and the share will be deleted. the only time this doesn't apply is if we use a special account, like a premium account. so we should remove these deletes before we merge the 100 branch into main
gunjansingh-msft
merged commit 12ccb88
into
feature/storage/stg100base
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines