-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add OpenRewrite recipes and samples for azure-security-keyvault-administration to automate migration to v2 #46965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DoggyDoggyDoggy
wants to merge
39
commits into
Azure:main
Choose a base branch
from
DoggyDoggyDoggy:azure-security-keyvault-administration-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
88f5c3f
azure-security-keyvault-certificates samples and recipes
DoggyDoggyDoggy b70cf75
Added dependency
DoggyDoggyDoggy d855830
DefaultAzureCredentialBuilder recipe
DoggyDoggyDoggy 3450f8b
CI setup
DoggyDoggyDoggy 0f9f509
CI fix
DoggyDoggyDoggy c3cfdb6
CI fix
DoggyDoggyDoggy bfbed66
Update checkstyle-suppressions.xml to use the new linting extensions …
srnagar 5c63fc4
fix checkstyle
srnagar 1f40d45
azure-security-keyvault-certificates samples and recipes
DoggyDoggyDoggy f6d46ae
azure-security-keyvault-certificates dependency
DoggyDoggyDoggy 0537417
CI setup
DoggyDoggyDoggy dd2de66
CI fix. Wrong directory
DoggyDoggyDoggy aa39392
Recipes for azure-security-keyvault-secrets
DoggyDoggyDoggy b531042
Samples for azure-security-keyvault-secrets
DoggyDoggyDoggy ebe2105
Remove wrong for recipes
DoggyDoggyDoggy 96fd50f
CI setup
DoggyDoggyDoggy c0b1afc
Restore old samples for com.azure.security.keyvault.certificates
DoggyDoggyDoggy e40db53
version_client.txt fix
DoggyDoggyDoggy ced2396
openrewrite-sample-compiler-ci.yml fix
DoggyDoggyDoggy 6d42b4b
linting_suppression_generator
DoggyDoggyDoggy fc491a7
linting_suppression_generator
DoggyDoggyDoggy 0a7208f
Samples and recipes for security-keyvault-keys
DoggyDoggyDoggy cfc8104
Dependencies for security-keyvault-keys
DoggyDoggyDoggy c6d7b90
Update openrewrite-sample-compiler-ci.yml
DoggyDoggyDoggy 35ae4dd
CI setup
DoggyDoggyDoggy a959c60
Samples and recipies for azure-security-keyvault-administration
DoggyDoggyDoggy de6172e
Dependencies for azure-security-keyvault-administration
DoggyDoggyDoggy 7c54d26
Setup CI for azure-security-keyvault-administration
DoggyDoggyDoggy 15167e8
CI fix
DoggyDoggyDoggy 28a05f7
Add recipe for KeyVaultSettingsClient
DoggyDoggyDoggy 3da90f6
Add recipe for SecretClientBuilder
DoggyDoggyDoggy fd44788
Merge branch 'main' into azure-security-keyvault-keys-pr
srnagar c0ced63
Merge branch 'main' into azure-security-keyvault-certificates-pr
DoggyDoggyDoggy 02bda29
Merge pull request #30 from DoggyDoggyDoggy/azure-security-keyvault-c…
DoggyDoggyDoggy 834d1d9
Merge branch 'main' into azure-security-keyvault-keys-pr
DoggyDoggyDoggy fe218ee
Merge pull request #31 from DoggyDoggyDoggy/azure-security-keyvault-k…
DoggyDoggyDoggy fd69c65
Merge branch 'main' into azure-security-keyvault-secrets-pr
DoggyDoggyDoggy b12e791
Merge pull request #32 from DoggyDoggyDoggy/azure-security-keyvault-s…
DoggyDoggyDoggy 483eb62
Merge branch 'main' into azure-security-keyvault-administration-pr
DoggyDoggyDoggy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...-INF/rewrite/migrationRecipes/azure-security-keyvault-administration/LibraryMigration.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
| # -------------------------------------------------------------------- | ||
| # Migration Recipes for Azure security-keyvault-keys Library | ||
| # -------------------------------------------------------------------- | ||
| type: specs.openrewrite.org/v1beta/recipe | ||
| name: com.azure.openrewrite.migration.security.keyvault.administration | ||
| displayName: Migrate from azure-security-keyvault-keys to next generation stack | ||
| description: This recipe migrates the Azure keyvault-keys library to the next generation stack. | ||
| recipeList: | ||
|
|
||
| - com.azure.openrewrite.recipe.azure.security.keyvault.administration | ||
| - com.azure.openrewrite.recipe.azure.security.keyvault.administration.models |
96 changes: 96 additions & 0 deletions
96
...re-security-keyvault-administration/com.azure.security.keyvault.administration.models.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| type: specs.openrewrite.org/v1beta/recipe | ||
| name: com.azure.openrewrite.recipe.azure.security.keyvault.administration.models | ||
| displayName: Migrate from azure.security.keyvault.administration.models to next generation stack | ||
| description: This recipe migrates the azure.security.keyvault.administration.models package to the next generation stack. | ||
| recipeList: | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRoleAssignment | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRoleAssignment | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRoleAssignment | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRoleDefinition | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRoleDefinition | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRoleDefinition | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultBackupOperation | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultBackupOperation | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultBackupOperation | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRestoreOperation | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRestoreOperation | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRestoreOperation | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRestoreResult | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRestoreResult | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRestoreResult | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRoleAssignment | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRoleAssignment | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRoleAssignment | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultRoleScope | ||
| # -------------------------------------------------------------------- | ||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultRoleScope | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultRoleScope | ||
|
|
||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: "*..KeyVaultRoleScope fromString(..)" | ||
| newMethodName: fromValue | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultGetSettingsResult | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultGetSettingsResult | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultGetSettingsResult | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultSetting | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultSetting | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultSetting | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultSelectiveKeyRestoreResult | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultSelectiveKeyRestoreResult | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultSelectiveKeyRestoreResult | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultSelectiveKeyRestoreOperation | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.models.KeyVaultSelectiveKeyRestoreOperation | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.models.KeyVaultSelectiveKeyRestoreOperation |
65 changes: 65 additions & 0 deletions
65
...pes/azure-security-keyvault-administration/com.azure.security.keyvault.administration.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
| type: specs.openrewrite.org/v1beta/recipe | ||
| name: com.azure.openrewrite.recipe.azure.security.keyvault.administration | ||
| displayName: Migrate from azure.security.keyvault.administration to next generation stack | ||
| description: This recipe migrates the azure.security.keyvault.administration package to the next generation stack. | ||
| recipeList: | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultAccessControlClientBuilder | ||
| # -------------------------------------------------------------------- | ||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.azure.security.keyvault.administration.KeyVaultSettingsClientBuilder vaultUrl(..) | ||
| newMethodName: endpoint | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultSettingsClientBuilder | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultSettingsClientBuilder | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultAccessControlClientBuilder | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.azure.security.keyvault.administration.KeyVaultAccessControlClientBuilder vaultUrl(..) | ||
| newMethodName: endpoint | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultAccessControlClientBuilder | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultAccessControlClientBuilder | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultBackupClientBuilder | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.azure.security.keyvault.administration.KeyVaultBackupClientBuilder vaultUrl(..) | ||
| newMethodName: endpoint | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultBackupClientBuilder | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultBackupClientBuilder | ||
| # -------------------------------------------------------------------- | ||
| # KeyVaultAccessControlClient | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultAccessControlClient | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultAccessControlClient | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultBackupClient | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultBackupClient | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultBackupClient | ||
|
|
||
| # -------------------------------------------------------------------- | ||
| # KeyVaultSettingsClient | ||
| # -------------------------------------------------------------------- | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.administration.KeyVaultSettingsClient | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.administration.KeyVaultSettingsClient | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...-security-keyvault-administration/AccessControlHelloWorld/v1/AccessControlHelloWorld.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since KV library wanted to make it more specific and name this as
vaultUrl, we should do this customization in all KV libraries to usevaultUrlrather than the genericendpointmethod that is generated.cc: @vcolin7