Added new WriteStrategy ItemPatchIfExists #47034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
a team and
kirankumarkolli
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new write strategy ItemPatchIfExists to the Azure Cosmos Spark connector, which allows patch operations to gracefully skip documents that don't exist instead of failing the job.
- Added
ItemPatchIfExistsenum value to theItemWriteStrategyenumeration - Updated point and bulk writers to handle the new strategy by ignoring 404/Not Found errors
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
SparkE2EWriteITest.scala |
Added integration test for the new ItemPatchIfExists strategy |
PointWriter.scala |
Updated patch operations to support ignoring not found errors |
CosmosConfig.scala |
Added ItemPatchIfExists to the enum and configuration parsing |
BulkWriter.scala |
Updated bulk writer to handle the new strategy |
configuration-reference.md |
Updated documentation to describe the new strategy |
CHANGELOG.md |
Added changelog entry for the new feature |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeet1995
approved these changes
Oct 17, 2025
nehrao1
approved these changes
Oct 17, 2025
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new WriteStrategy for the Spark connector allowing to use ItemPatch - but skip errors when documents with patch-instructions in the dataframe ebing written don't exist (anymore). The existing strategy "ItemPatch" would fail the Spark job because the 404/NotFound is a non-transient error. There are several use cases where customers want to pacth documents - but it is ok/accepted when the documents don't exist anymore - and this should be a no-op in that case instead of failing the entire job. The new write startegy
ItemPatchIfExistsallows that.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines