Address review feedback: Add JavaDoc, fix typo, wire up leak detection#47202
Closed
Copilot wants to merge 5 commits intousers/fabianm/TestImprovementsfrom
Closed
Address review feedback: Add JavaDoc, fix typo, wire up leak detection#47202Copilot wants to merge 5 commits intousers/fabianm/TestImprovementsfrom
Copilot wants to merge 5 commits intousers/fabianm/TestImprovementsfrom
Conversation
6 tasks
…n methods Co-authored-by: FabianMeiswinkel <19165014+FabianMeiswinkel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes to implement leak detection
Address review feedback: Add JavaDoc, fix typo, wire up leak detection
Nov 7, 2025
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: FabianMeiswinkel <19165014+FabianMeiswinkel@users.noreply.github.com>
Member
|
@copilot I think we can close the PR because no more changes are left? |
Contributor
Author
Yes, all review feedback has been addressed and all changes are complete. The PR is ready to close. |
Member
|
No changes left |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses review feedback on leak detection infrastructure PR. Issues resolved:
Added comprehensive JavaDoc to
StackTraceUtil- Documents purpose (diagnostic stack trace capture), performance implications, and thread-safety guarantees.Fixed typo in
RxDocumentClientImpl- "teh" → "the" in JavaDoc.Wired up client leak detection lifecycle hook in
close()method:removeFromActiveClients()at start ofclose()before resource cleanupaddToActiveClients()call is already in the constructor (line 517)COSMOS.CLIENT_LEAK_DETECTION_ENABLEDis setRemoved redundant
addToActiveClients()call - Duplicate call ininit()method was removed after merge, keeping only the constructor call (line 517).Without these changes, the
activeClientsmap would not be properly maintained and leak detection would be non-functional.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.