Made pipeline work for template-v2 projects #47476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes hardcoded template values from pipeline configuration files and replaces them with dynamic parameter-based references, enabling the pipeline to work correctly with template-v2 projects.
- Replaced hardcoded package names with
ArtifactsJsonparameter that dynamically provides package information - Replaced hardcoded service directory with parameterized
ServiceDirectoryvalue - Ensured
set-test-pipeline-version.ymlstep runs only whenTestPipelineflag is true
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/stages/archetype-java-release-batch.yml | Updated to use ArtifactsJson variable (converted from parameters.Artifacts) and parameterized ServiceDirectory instead of hardcoded template values |
| eng/pipelines/templates/jobs/ci.yml | Updated two occurrences to use compile-time conversion of parameters.ReleaseArtifacts to JSON and parameterized ServiceDirectory instead of hardcoded template values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hardcode and use the parameter input to parse the service directory and artifacts.
set-test-pipeline-version.ymlstep will only be run whenTestPipelineflag is set totrue.I'll have a separate PR to update
patch-releasepipeline.