Skip to content

mgmt redis , fix live test failures #47505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
v-huizhu2 wants to merge 2 commits into from
Closed

mgmt redis , fix live test failures #47505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cacafc1
test(redis): disable tests due to internal policy restrictions
v-huizhu2 Dec 8, 2025
e69b486
test(redis): disable public network access update test
v-huizhu2 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...anager-redis/src/test/java/com/azure/resourcemanager/redis/RedisCacheOperationsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
public class RedisCacheOperationsTests extends RedisManagementTest {

@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@SuppressWarnings("unchecked")
Comment on lines +42 to 43
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The order of @Test and @Disabled annotations is inconsistent across the test class. At line 214, the existing disabled test canRedisVersionUpdate() has @Disabled before @Test, while the newly added disabled tests have @Test before @Disabled.

While both orders are functionally equivalent in JUnit 5, maintaining consistency within the same file improves code readability. Consider using the same order as the existing disabled test:

@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test

Copilot uses AI. Check for mistakes.
public void canCRUDRedisCache() throws Exception {
// Create
Expand Down Expand Up @@ -241,6 +242,7 @@ public void canRedisVersionUpdate() {
}

@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
Comment on lines 244 to +245
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The order of @Test and @Disabled annotations is inconsistent with the existing disabled test at line 214. For consistency within this file, consider placing @Disabled before @Test:

@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test
Suggested change
@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test

Copilot uses AI. Check for mistakes.
public void canCRUDLinkedServers() throws Exception {

RedisCache rgg = redisManager.redisCaches()
Expand Down Expand Up @@ -298,6 +300,7 @@ public void canCRUDLinkedServers() throws Exception {
}

@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
Comment on lines 302 to +303
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The order of @Test and @Disabled annotations is inconsistent with the existing disabled test at line 214. For consistency within this file, consider placing @Disabled before @Test:

@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test

Copilot uses AI. Check for mistakes.
public void canCreateRedisWithRdbAof() {
StorageAccount storageAccount = storageManager.storageAccounts()
.define(saName)
Expand Down Expand Up @@ -349,6 +352,7 @@ public void canCreateRedisWithRdbAof() {
}

@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
Comment on lines 354 to +355
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The order of @Test and @Disabled annotations is inconsistent with the existing disabled test at line 214. For consistency within this file, consider placing @Disabled before @Test:

@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test

Copilot uses AI. Check for mistakes.
public void canCreateRedisCacheWithDisablePublicNetworkAccess() {
resourceManager.resourceGroups().define(rgNameSecond).withRegion(Region.US_CENTRAL);

Expand All @@ -363,6 +367,7 @@ public void canCreateRedisCacheWithDisablePublicNetworkAccess() {
}

@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
Comment on lines 369 to +370
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The order of @Test and @Disabled annotations is inconsistent with the existing disabled test at line 214. For consistency within this file, consider placing @Disabled before @Test:

@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test
Suggested change
@Test
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Disabled("This request was denied due to internal policy. Local authentication methods are not allowed.")
@Test

Copilot uses AI. Check for mistakes.
public void canUpdatePublicNetworkAccess() {
resourceManager.resourceGroups().define(rgNameSecond).withRegion(Region.US_CENTRAL);

Expand Down
Loading