[test] fix flaky test writing temp files #27950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test create temporary folders using test case titles. It started to fail recently likely due to newer NodeJS version 21.3.0. There are some changes around `fs.writeFileSync`. nodejs/node#49884 Same tests were passing on 21.2.0. This PR changes the test to use simpler names.
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
simple names failing too. must be a different reason, for example, wrong paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test create temporary folders using test case titles. It started to fail recently likely due to newer NodeJS version 21.3.0. There are some changes around
fs.writeFileSync.nodejs/node#49884
Same tests were passing on 21.2.0.
This PR changes the test to use simpler names.