[EngSys] unpin NodeTestVersion of 21.2.0 #27999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that a fix to `fs.writeFileSync` has been released. Revert "Temporarily pin NodeTestVersion of v21 to 21.2.0 (Azure#27951)" This reverts commit b1a31b3.
jeremymeng
requested review from
benbp,
ckairen,
mikeharder and
weshaggard
as code owners
xirzec
approved these changes
Dec 6, 2023
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Dec 14, 2023
because of nodejs/node#51081 Revert "[EngSys] unpin NodeTestVersion of 21.2.0 (Azure#27999)" This reverts commit 884d750.
jeremymeng
added a commit
that referenced
this pull request
Dec 14, 2023
Because of a regression in v21.4.0, running our tests with `esm` package is broken. nodejs/node#51081 Revert "[EngSys] unpin NodeTestVersion of 21.2.0 (#27999)" This reverts commit 884d750.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that a fix to
fs.writeFileSynchas been released.Revert "Temporarily pin NodeTestVersion of v21 to 21.2.0 (#27951)"
This reverts commit b1a31b3.
Issues associated with this PR
#27957