Skip to content

Conversation

@jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Jul 11, 2025

to adapt changes in open-telemetry/opentelemetry-js-contrib#2928

Resolves issue #35187

Copilot AI review requested due to automatic review settings July 11, 2025 20:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the instrumentation links in the monitor-opentelemetry README to reflect the new package structure in the OpenTelemetry JS Contrib repository.

  • Swapped old plugins/node URLs to the new packages/instrumentation-* paths for supported libraries.
  • Updated the “Other OpenTelemetry Instrumentations” link to point to the new packages directory.
  • Ensured consistency across Distributed Tracing and Logs sections.
Comments suppressed due to low confidence (3)

sdk/monitor/monitor-opentelemetry/README.md:204

  • The new instrumentation links under Distributed Tracing are no longer nested under the HTTP/HTTPS bullet—consider adding two spaces of indentation before each - [MongoDB], - [MySQL], etc., to maintain a proper nested list structure.
- [MongoDB](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/instrumentation-mongodb)

sdk/monitor/monitor-opentelemetry/README.md:217

  • In the Logs section, the Bunyan and Winston entries appear unindented compared to the previous nested list style—add consistent indentation (e.g., two spaces) to indicate these are list items under the Logs heading.
- [Bunyan](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/instrumentation-bunyan)

sdk/monitor/monitor-opentelemetry/README.md:221

  • This line was dedented and no longer appears as a list or paragraph under Logs—consider restoring a blank line above and formatting it as either an indented paragraph or bullet to keep it visually grouped with the Logs items.
Other OpenTelemetry Instrumentations are available [here](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages) and could be added using TracerProvider in AzureMonitorOpenTelemetryClient.

@jeremymeng
Copy link
Member Author

Already fixed in PR #35232

@jeremymeng jeremymeng closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants