[mgmt] comptefleet release #35544
[mgmt] comptefleet release #35544
Conversation
kazrael2119
requested review from
qiaozha,
MaryGao,
a team,
jeremymeng and
xirzec
as code owners
github-actions
bot
added
the
Mgmt
There was a problem hiding this comment.
Pull Request Overview
This PR implements a management SDK release for the Azure Compute Fleet service, updating from version 2024-11-01 to 2025-07-01-preview. The release includes significant API changes, new functionality, and improved code organization.
Key changes:
- API version upgrade to 2025-07-01-preview with new Fleet modes and capacity types
- Restructured codebase with improved organization and new helper modules
- Added new operations for virtual machine management and fleet cancellation
Reviewed Changes
Copilot reviewed 80 out of 83 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/computefleet/ci.mgmt.yml | Removed empty lines for cleaner YAML formatting |
| vitest configuration files | Minor formatting improvements and property ordering |
| tsp-location.yaml | Updated commit hash and added additionalDirectories property |
| test files | Updated to skip tests and changed resource group naming |
| src/static-helpers/urlTemplate.ts | New RFC 6570 URI template implementation |
| src/static-helpers/cloudSettingHelpers.ts | New Azure cloud environment helper utilities |
| src/models/models.ts | Major model updates with new Fleet modes, capacity types, and API operations |
| src/api/ files | Complete restructuring of API client with new operations and improved organization |
| samples/ files | Updated samples to use new API version and improved async patterns |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| const prefixFromOptions = options?.userAgentOptions?.userAgentPrefix; | ||
| const userAgentInfo = `azsdk-js-arm-computefleet/1.0.1`; | ||
| const userAgentInfo = `azsdk-js-arm-computefleet/1.0.0-beta.1`; |
There was a problem hiding this comment.
The version string is hardcoded. Consider extracting this to a constant or reading it from package.json to ensure it stays in sync with the actual package version.
| const userAgentInfo = `azsdk-js-arm-computefleet/1.0.0-beta.1`; | |
| const userAgentInfo = `azsdk-js-arm-computefleet/${pkg.version}`; |
Copilot uses AI. Check for mistakes.
sdk/computefleet/arm-computefleet/test/public/computefleet_operations_test.spec.ts
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
@kazrael2119 there is on-going pr to update the spec, Azure/azure-rest-api-specs#36795, could you refresh until this pr is merged? |
got it |
|
close as use #35733 instead |
https://github.com/Azure/sdk-release-request/issues/6475