-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[@azure/batch-rest] Update version to 1.0.0-beta.4 #36067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Removed CreateCertificate, ListCertificates, CancelCertificateDeletion, DeleteCertificate, and GetCertificate interfaces and their associated types from parameters.ts and responses.ts. - Updated the pools.spec.ts test file to reflect changes in VM image references and removed a test for listing pool usage metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @azure/batch-rest
package to version 1.0.0-beta.4, featuring significant breaking changes by removing certificate management APIs and adding several new features for enhanced pool configuration.
Key Changes:
- Removes all certificate management APIs and related types as certificates are now deprecated in favor of Azure KeyVault Extension
- Adds IPv6 support, customer-managed key (CMK) support, and job-level FIFO scheduling capabilities
- Updates API version from 2024-07-01.20.0 to 2025-06-01
Reviewed Changes
Copilot reviewed 18 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
package.json | Updates version to 1.0.0-beta.4 and refreshes dependencies |
CHANGELOG.md | Documents breaking changes and new features for beta.4 release |
src/batchClient.ts | Updates default API version to 2025-06-01 |
src/models.ts | Removes certificate types, adds CMK/IPv6/FIFO support models |
src/outputModels.ts | Removes certificate output types, adds new feature output models |
src/responses.ts | Removes certificate-related response types |
src/parameters.ts | Removes certificate parameter types |
src/isUnexpected.ts | Removes certificate response handlers |
src/clientDefinitions.ts | Removes certificate API definitions |
test/pools.spec.ts | Updates test configurations and removes deprecated test |
Configuration files | Updates TypeScript configs, test setup, and metadata |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
const updateOptions: ReplacePoolPropertiesParameters = { | ||
body: { | ||
metadata: [{ name: "foo", value: "bar" }], | ||
applicationPackageReferences: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The removal of the certificateReferences: []
property is correct given the deprecation of certificate support, but ensure this change doesn't break existing pool configurations that might still rely on this field for backward compatibility.
applicationPackageReferences: [], | |
applicationPackageReferences: [], | |
certificateReferences: [], |
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists