Skip to content

Conversation

wanghoppe
Copy link
Member

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Hoppe Wang added 3 commits September 23, 2025 18:20
- Removed CreateCertificate, ListCertificates, CancelCertificateDeletion, DeleteCertificate, and GetCertificate interfaces and their associated types from parameters.ts and responses.ts.
- Updated the pools.spec.ts test file to reflect changes in VM image references and removed a test for listing pool usage metrics.
@Copilot Copilot AI review requested due to automatic review settings September 27, 2025 00:12
@github-actions github-actions bot added Batch dev-tool Issues related to the Azure SDK for JS dev-tool labels Sep 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @azure/batch-rest package to version 1.0.0-beta.4, featuring significant breaking changes by removing certificate management APIs and adding several new features for enhanced pool configuration.

Key Changes:

  • Removes all certificate management APIs and related types as certificates are now deprecated in favor of Azure KeyVault Extension
  • Adds IPv6 support, customer-managed key (CMK) support, and job-level FIFO scheduling capabilities
  • Updates API version from 2024-07-01.20.0 to 2025-06-01

Reviewed Changes

Copilot reviewed 18 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates version to 1.0.0-beta.4 and refreshes dependencies
CHANGELOG.md Documents breaking changes and new features for beta.4 release
src/batchClient.ts Updates default API version to 2025-06-01
src/models.ts Removes certificate types, adds CMK/IPv6/FIFO support models
src/outputModels.ts Removes certificate output types, adds new feature output models
src/responses.ts Removes certificate-related response types
src/parameters.ts Removes certificate parameter types
src/isUnexpected.ts Removes certificate response handlers
src/clientDefinitions.ts Removes certificate API definitions
test/pools.spec.ts Updates test configurations and removes deprecated test
Configuration files Updates TypeScript configs, test setup, and metadata
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

const updateOptions: ReplacePoolPropertiesParameters = {
body: {
metadata: [{ name: "foo", value: "bar" }],
applicationPackageReferences: [],
Copy link
Preview

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The removal of the certificateReferences: [] property is correct given the deprecation of certificate support, but ensure this change doesn't break existing pool configurations that might still rely on this field for backward compatibility.

Suggested change
applicationPackageReferences: [],
applicationPackageReferences: [],
certificateReferences: [],

Copilot uses AI. Check for mistakes.

Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure-rest/batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Batch dev-tool Issues related to the Azure SDK for JS dev-tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant