Skip to content

Conversation

kevinzz6
Copy link
Member

Packages impacted by this PR

synapse-artifacts

Issues associated with this PR

Describe the problem that is addressed by this PR

SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

https://github.com/Azure/azure-rest-api-specs/tree/222af3670e36c5083cb0dc8a9c2677a8f77f8958/specification/synapse/data-plane/Microsoft.Synapse

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@kevinzz6 kevinzz6 requested a review from joheredi as a code owner September 28, 2025 05:51
@Copilot Copilot AI review requested due to automatic review settings September 28, 2025 05:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the synapse-artifacts SDK with a new Swagger specification release from September 2025. The changes primarily focus on updating generated code to use the latest API specification, with several key refactoring improvements to generated TypeScript code.

  • Updates the Swagger spec commit reference to use the latest API specification
  • Refactors imports to remove type qualifiers and use direct imports where appropriate
  • Updates JSDoc comments to remove hyphens from parameter descriptions for cleaner formatting
  • Restructures generated code by moving operation specifications to the end of files

Reviewed Changes

Copilot reviewed 56 out of 56 changed files in this pull request and generated no comments.

File Description
swagger/README.md Updates the Swagger spec commit reference to the latest version
src/pagingHelper.ts Improves JSDoc formatting and function parameter structure
src/operationsInterfaces/*.ts Updates import statements and JSDoc comment formatting across all operation interfaces
src/operations/*.ts Major refactoring of generated operation files - removes type imports, updates JSDoc formatting, and moves operation specifications to end of files

@kazrael2119
Copy link
Member

to fix these failures, you need
1: run lint:fix to fix lint errors
2: build your library after 1
3: if needed, format your library

@MaryGao
Copy link
Member

MaryGao commented Sep 29, 2025

to fix these failures, you need 1: run lint:fix to fix lint errors 2: build your library after 1 3: if needed, format your library

@kevinzz6 Could you try the steps to fix it?

@kazrael2119 is this introduced by codegen? any issue to track that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants