fix-ppaf-enablement #36090
Open
fix-ppaf-enablement #36090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanrao23
requested review from
aditishree1,
sajeetharan and
topshot99
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the default value of PPAF (Partition-level Failover) flags by moving the partition-level failover configuration from the connection policy to the global endpoint manager. The change ensures that partition-level failover is enabled by default as intended.
Key Changes
- Removed
enablePartitionLevelFailoverparameter from TimeoutFailoverRetryPolicy constructor - Updated all references to access partition-level failover settings through
globalEndpointManagerinstead ofconnectionPolicy - Removed automatic PPAF feature flag tracking from user agent since it's now enabled by default
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| timeoutFailoverRetryPolicy.ts | Removed enablePartitionLevelFailover parameter and updated condition to use globalEndpointManager |
| retryUtility.ts | Removed enablePartitionLevelFailover parameter from TimeoutFailoverRetryPolicy constructor call |
| RequestHandler.ts | Updated partition-level failover checks to use globalEndpointManager instead of connectionPolicy |
| globalEndpointManager.ts | Removed refreshPPAFFeatureFlag call since PPAF is now enabled by default |
| platform.ts | Removed automatic PPAF feature flag tracking from user agent and added TODO comment |
| ClientContext.ts | Updated isPartitionLevelFailOverEnabled method to check globalEndpointManager instead of connectionPolicy |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
LGTM. |
ajnovice
reviewed
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
#35967
Describe the problem that is addressed by this PR
This PR is follow up of #35954 for fixing the default value of ppaf flags.
This PR makes the following changes:
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists