Skip to content

[notification-hubs] fix TypeError when parsing AppleTemplateRegistrationDescription #36114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2025
Merged

[notification-hubs] fix TypeError when parsing AppleTemplateRegistrationDescription #36114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3e62bb
[notification-hubs] fix TypeError when parsing AppleTemplateRegistrat…
jeremymeng Oct 3, 2025
ce601f3
update CHANGELOG
jeremymeng Oct 6, 2025
4dc7dfa
fix analyze PR check
jeremymeng Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/notificationhubs/notification-hubs/src/serializers/registrationSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,14 +502,14 @@ export const registrationDescriptionParser: RegistrationDescriptionParser = {
};

function getHeadersOrUndefined(
value?: { Header: string; Value: string }[],
value?: { Header: string; Value: string }[] | { Header: string; Value: string },
): Record<string, string> | undefined {
if (!isDefined(value)) {
return undefined;
}

const headerObj: Record<string, string> = {};
for (const { Header, Value } of value) {
for (const { Header, Value } of Array.isArray(value) ? value : [value]) {
headerObj[Header] = Value;
}

Expand Down
31 changes: 31 additions & 0 deletions sdk/notificationhubs/notification-hubs/test/internal/unit/registrationSerializer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,24 @@ const APPLE_TEMPLATE_REGISTRATION = `<?xml version="1.0" encoding="utf-8"?>
</content>
</entry>`;

const APPLE_TEMPLATE_REGISTRATION_SINGLE_APNSHEADER = `<?xml version="1.0" encoding="utf-8"?>
<entry xmlns="http://www.w3.org/2005/Atom">
<content type="application/xml">
<AppleTemplateRegistrationDescription xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.microsoft.com/netservices/2010/10/servicebus/connect">
<Tags>myTag,myOtherTag</Tags>
<RegistrationId>{Registration Id}</RegistrationId>
<DeviceToken>{DeviceToken}</DeviceToken>
<BodyTemplate><![CDATA[{Template for the body}]]></BodyTemplate>
<ApnsHeaders>
<ApnsHeader>
<Header>apns-priority</Header>
<Value>10</Value>
</ApnsHeader>
</ApnsHeaders>
</AppleTemplateRegistrationDescription>
</content>
</entry>`;

const BAIDU_REGISTRATION = `<?xml version="1.0" encoding="utf-8"?>
<entry xmlns="http://www.w3.org/2005/Atom">
<content type="application/xml">
Expand Down Expand Up @@ -337,6 +355,19 @@ describe("parseRegistrationEntry", () => {
assert.equal(registration.apnsHeaders!["apns-expiration"], "0");
});

it("should parse an apple template registration description with single apns header", async () => {
const registration = (await registrationDescriptionParser.parseRegistrationEntry(
APPLE_TEMPLATE_REGISTRATION_SINGLE_APNSHEADER,
)) as AppleTemplateRegistrationDescription;

assert.equal(registration.kind, "AppleTemplate");
assert.equal(registration.registrationId, "{Registration Id}");
assert.equal(registration.deviceToken, "{DeviceToken}");
assert.deepEqual(registration.tags, ["myTag", "myOtherTag"]);
assert.equal(registration.bodyTemplate, "{Template for the body}");
assert.equal(registration.apnsHeaders!["apns-priority"], "10");
});

it("should parse an Baidu registration description", async () => {
const registration = (await registrationDescriptionParser.parseRegistrationEntry(
BAIDU_REGISTRATION,
Expand Down