-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Upgrade glob from 11.x to 12.0.0 #36697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: jeremymeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the glob dependency from version ^11.0.3 to ^12.0.0 in two packages. The upgrade is safe as the breaking changes in glob 12.0.0 only affect CLI usage, while both packages use the API functions (glob() and globSync()), which remain backward compatible.
Key Changes
- Updated
globdependency specification from ^11.0.3 to ^12.0.0 in package.json files - Updated pnpm-lock.yaml to reflect the new dependency resolution
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/apimanagement/api-management-custom-widgets-scaffolder/package.json | Upgraded glob dependency from ^11.0.3 to ^12.0.0 |
| common/tools/eslint-plugin-azure-sdk/package.json | Upgraded glob dependency from ^11.0.3 to ^12.0.0 |
| pnpm-lock.yaml | Updated lock file with new glob 12.0.0 resolution and dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Packages impacted by this PR
@azure/eslint-plugin-azure-sdk@azure/api-management-custom-widgets-scaffolderIssues associated with this PR
Addresses dependency upgrade requirement for glob package.
Describe the problem that is addressed by this PR
Two packages depend on glob ^11.0.3. Version 12.0.0 is available and should be adopted.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Direct version bump in package.json. Breaking changes in glob 12.0.0 only affect CLI usage; API functions (
globandglobSync) remain compatible.Are there test cases added in this PR? (If not, why?)
No new tests needed. Existing tests validate compatibility:
Provide a list of related PRs (if any)
None
Command used to generate this PR:**(Applicable only to SDK release request PRs)
N/A
Checklists
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.