Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 19, 2025

Packages impacted by this PR

  • @azure/eslint-plugin-azure-sdk
  • @azure/api-management-custom-widgets-scaffolder

Issues associated with this PR

Addresses dependency upgrade requirement for glob package.

Describe the problem that is addressed by this PR

Two packages depend on glob ^11.0.3. Version 12.0.0 is available and should be adopted.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Direct version bump in package.json. Breaking changes in glob 12.0.0 only affect CLI usage; API functions (glob and globSync) remain compatible.

Are there test cases added in this PR? (If not, why?)

No new tests needed. Existing tests validate compatibility:

  • eslint-plugin-azure-sdk: 659 tests pass
  • api-management-custom-widgets-scaffolder: 3 tests pass

Provide a list of related PRs (if any)

None

Command used to generate this PR:**(Applicable only to SDK release request PRs)

N/A

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)
Original prompt

This section details on the original issue you should resolve

<issue_title>Dependency package glob has a new version available</issue_title>
<issue_description>We have identified a dependency on version 11.1.0 of glob. A new version (12.0.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run 'pnpm install' to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.</issue_description>

Comments on the Issue (you are @copilot in this section)

@jeremymeng Breaking changes only affect CLI. No Impact to our repository.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 19, 2025
Copilot AI changed the title [WIP] Update glob package to version 12.0.0 Upgrade glob from 11.x to 12.0.0 Nov 19, 2025
Copilot AI requested a review from jeremymeng November 19, 2025 23:49
Copilot finished work on behalf of jeremymeng November 19, 2025 23:49
@jeremymeng jeremymeng marked this pull request as ready for review November 20, 2025 00:37
Copilot AI review requested due to automatic review settings November 20, 2025 00:37
@jeremymeng jeremymeng requested review from a team, deyaaeldeen and xirzec as code owners November 20, 2025 00:37
Copilot finished reviewing on behalf of jeremymeng November 20, 2025 00:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the glob dependency from version ^11.0.3 to ^12.0.0 in two packages. The upgrade is safe as the breaking changes in glob 12.0.0 only affect CLI usage, while both packages use the API functions (glob() and globSync()), which remain backward compatible.

Key Changes

  • Updated glob dependency specification from ^11.0.3 to ^12.0.0 in package.json files
  • Updated pnpm-lock.yaml to reflect the new dependency resolution

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdk/apimanagement/api-management-custom-widgets-scaffolder/package.json Upgraded glob dependency from ^11.0.3 to ^12.0.0
common/tools/eslint-plugin-azure-sdk/package.json Upgraded glob dependency from ^11.0.3 to ^12.0.0
pnpm-lock.yaml Updated lock file with new glob 12.0.0 resolution and dependencies
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency package glob has a new version available

3 participants