Fix incomplete abort signal handling in memory store update poller #36710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- Add options parameter to buildRunningOperation function - Handle both user-provided and poll-specific abort signals - Remove both listeners in finally block to prevent memory leaks - Matches reference implementation in pollingHelpers.ts Co-authored-by: glharper <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on v2 update for LRO poller memory operations
Fix incomplete abort signal handling in memory store update poller
Nov 20, 2025
Copilot finished work on behalf of
glharper
November 20, 2025 21:58
glharper
approved these changes
Nov 21, 2025
glharper
requested review from
ZachhK,
bobogogo1990,
dargilco and
ganeshyb
as code owners
glharper
merged commit 722799d
into
glharper/proj-mem-store-update
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sendPollRequestfunction inmemoryStoreUpdatePoller.tsonly handled poll-specific abort signals (pollOptions?.abortSignal), ignoring user-provided abort signals fromcreateMemoryStoreUpdatePolleroptions. This prevented proper cancellation propagation.Changes
optionsparameter tobuildRunningOperationto access user-provided abort signaloptions.abortSignalandpollOptions?.abortSignalinsendPollRequestImplementation now matches the reference pattern in
pollingHelpers.ts(lines 67-90).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.