Skip to content

Conversation

@kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Nov 21, 2025

Copilot AI review requested due to automatic review settings November 21, 2025 08:38
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Nov 21, 2025
Copilot finished reviewing on behalf of kazrael2119 November 21, 2025 08:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @azure/arm-policyinsights package from version 6.0.0 to 6.1.0. The primary purpose is to align the PolicyStates API with a simpler, non-paginated response pattern while maintaining backward compatibility for other operations. The changes also include modernization of code style, TypeScript configurations, and sample code to follow current best practices.

Key Changes:

  • Convert PolicyStates list operations from PagedAsyncIterableIterator to Promise-based responses
  • Update copyright header format across all source files to use // style comments
  • Add type keyword for type-only imports throughout the codebase
  • Modernize sample code to use await instead of iterator patterns for non-paginated operations
  • Update TypeScript compiler options in sample configurations

Reviewed Changes

Copilot reviewed 273 out of 275 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/policyInsightsClient.ts Version bump to 6.1.0, header format update, type imports
src/operationsInterfaces/policyStates.ts Breaking: Changed return types from PagedAsyncIterableIterator to Promise for list operations
src/operations/policyStates.ts Breaking: Removed pagination logic, changed methods from private to public
test/policyinsights_example.spec.ts Added new test for policyStates.listQueryResultsForSubscription
samples/**/*.ts Updated samples to use direct await instead of iterators for PolicyStates, added type imports
vitest.esm.config.ts New ESM test configuration file
tsconfig.json Removed empty files array
Various operation files Header format updates, type imports, code formatting improvements
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-policyinsights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant