-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[App Configuration] - Head request support #36959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds HEAD request support to the App Configuration client through a new checkConfigurationSettings method. This allows clients to efficiently check if configuration settings have changed by retrieving only HTTP headers (including ETags) without the response body.
Changes:
- Added
checkConfigurationSettingsmethod that performs HEAD requests to check configuration settings status - Implemented proper handling of 200 (success) and 304 (not modified) responses with ETag support
- Added comprehensive test coverage for the new method including ETag-based change detection
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts | Implements the new checkConfigurationSettings public method and private helper checkConfigurationSettingsRequest, adds imports for generated types |
| sdk/appconfiguration/app-configuration/test/public/index.spec.ts | Adds test suite covering basic HEAD requests, 304 responses with unchanged ETags, and 200 responses when content changes |
| sdk/appconfiguration/app-configuration/review/app-configuration-node.api.md | Updates API review file to include the new public method signature |
| sdk/appconfiguration/app-configuration/assets.json | Updates test assets tag to new recording version |
Comments suppressed due to low confidence (1)
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts:55
- The KeyValueListResult import appears to be unused. This import was added but is not referenced anywhere in the code. Consider removing it to keep imports clean.
} from "./generated/src/models/index.js";
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists