fix(loadtesting): Change reporter to use named export instead of defa… #36963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the PlaywrightReporter class to use a named export instead of a default export internally, while maintaining backward compatibility through the public API.
Key Changes:
- Changed class declaration from default export to named export in the source file
- Updated the reporter index to re-export as default (maintaining public API)
- Updated test imports to use named export
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/loadtesting/playwright/src/reporter/playwrightReporter.ts |
Changed class export from export default class to export class |
sdk/loadtesting/playwright/src/reporter/index.ts |
Updated to import named export and re-export as default to maintain backward compatibility |
sdk/loadtesting/playwright/test/reporter/playwrightReporter.spec.ts |
Updated test file to use named import from source file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ult export
Packages impacted by this PR
@azure/playwright
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists