Skip to content

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented Jul 27, 2021

Primary PR
Minor fix PR

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Batch label Jul 27, 2021
Updated generation

Generated comments.

Spec changes

Missing comma.

Spec fixe

Spec updates

Spec updates

Fixed VirtualMachineConfiguration

Spec changes

Spec changes

Spec changes

Updated ContainerRegistry

Updated ProtocolLayer

Fix object comparison

Fixed generator System.Object issue, NodeVMExtension.VmExtension casing
Readme formatting
@paterasMSFT paterasMSFT force-pushed the mipatera/dataplane20210601 branch from 4114f5a to 2278a77 Compare July 27, 2021 20:47
Updated version
@paterasMSFT paterasMSFT force-pushed the mipatera/dataplane20210601 branch from 2278a77 to c8695d4 Compare July 27, 2021 20:49
@paterasMSFT paterasMSFT marked this pull request as ready for review July 30, 2021 01:15
@paterasMSFT paterasMSFT enabled auto-merge (squash) July 30, 2021 19:56
@paterasMSFT paterasMSFT merged commit 706e485 into main Jul 30, 2021
@paterasMSFT paterasMSFT deleted the mipatera/dataplane20210601 branch July 30, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants