Azure Networking 2021-03-01 implemented. #23585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailTryakhov
requested review from
archerzz,
ArcturusZhang,
fengzhou-msft,
m-nash and
yungezz
as code owners
archerzz
reviewed
Aug 27, 2021
sdk/network/Microsoft.Azure.Management.Network/src/Generated/UsagesOperations.cs
Outdated
Show resolved
Hide resolved
archerzz
suggested changes
Aug 27, 2021
There was a problem hiding this comment.
- You need to update the metadata in https://github.com/Azure/azure-sdk-for-net/blob/main/eng/mgmt/mgmtmetadata/network_resource-manager.txt as well.
- Can you confirm that the
api-versionis rolled back to2019-06-01? Thanks.
MikhailTryakhov
requested review from
allenjzhang and
markcowl
as code owners
MikhailTryakhov
force-pushed
the
mitryakh/03-01-api
branch
2 times, most recently
from
63c17e6 to
34f1923
Compare
|
@archerzz now by some magic reason our api version is deprecated to 2020-11-01... Can you please help to find out why? |
When you submit the change, please make sure the modification in eng\mgmt\mgmtmetadata\network_resource-manager.txt is also included. |
MikhailTryakhov
force-pushed
the
mitryakh/03-01-api
branch
from
94fd60f to
3df98d4
Compare
|
@archerzz it's finally done! All metadata attached. Can you please review? |
archerzz
reviewed
Sep 3, 2021
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| /// <param name="zones">A list of availability zones denoting where the | ||
| /// resource needs to come from.</param> | ||
| /// <param name="identity">The identity of the application gateway, if | ||
| /// configured.</param> | ||
| public ApplicationGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), ApplicationGatewaySku sku = default(ApplicationGatewaySku), ApplicationGatewaySslPolicy sslPolicy = default(ApplicationGatewaySslPolicy), string operationalState = default(string), IList<ApplicationGatewayIPConfiguration> gatewayIPConfigurations = default(IList<ApplicationGatewayIPConfiguration>), IList<ApplicationGatewayAuthenticationCertificate> authenticationCertificates = default(IList<ApplicationGatewayAuthenticationCertificate>), IList<ApplicationGatewayTrustedRootCertificate> trustedRootCertificates = default(IList<ApplicationGatewayTrustedRootCertificate>), IList<ApplicationGatewayTrustedClientCertificate> trustedClientCertificates = default(IList<ApplicationGatewayTrustedClientCertificate>), IList<ApplicationGatewaySslCertificate> sslCertificates = default(IList<ApplicationGatewaySslCertificate>), IList<ApplicationGatewayFrontendIPConfiguration> frontendIPConfigurations = default(IList<ApplicationGatewayFrontendIPConfiguration>), IList<ApplicationGatewayFrontendPort> frontendPorts = default(IList<ApplicationGatewayFrontendPort>), IList<ApplicationGatewayProbe> probes = default(IList<ApplicationGatewayProbe>), IList<ApplicationGatewayBackendAddressPool> backendAddressPools = default(IList<ApplicationGatewayBackendAddressPool>), IList<ApplicationGatewayBackendHttpSettings> backendHttpSettingsCollection = default(IList<ApplicationGatewayBackendHttpSettings>), IList<ApplicationGatewayHttpListener> httpListeners = default(IList<ApplicationGatewayHttpListener>), IList<ApplicationGatewaySslProfile> sslProfiles = default(IList<ApplicationGatewaySslProfile>), IList<ApplicationGatewayUrlPathMap> urlPathMaps = default(IList<ApplicationGatewayUrlPathMap>), IList<ApplicationGatewayRequestRoutingRule> requestRoutingRules = default(IList<ApplicationGatewayRequestRoutingRule>), IList<ApplicationGatewayRewriteRuleSet> rewriteRuleSets = default(IList<ApplicationGatewayRewriteRuleSet>), IList<ApplicationGatewayRedirectConfiguration> redirectConfigurations = default(IList<ApplicationGatewayRedirectConfiguration>), ApplicationGatewayWebApplicationFirewallConfiguration webApplicationFirewallConfiguration = default(ApplicationGatewayWebApplicationFirewallConfiguration), SubResource firewallPolicy = default(SubResource), bool? enableHttp2 = default(bool?), bool? enableFips = default(bool?), ApplicationGatewayAutoscaleConfiguration autoscaleConfiguration = default(ApplicationGatewayAutoscaleConfiguration), IList<ApplicationGatewayPrivateLinkConfiguration> privateLinkConfigurations = default(IList<ApplicationGatewayPrivateLinkConfiguration>), IList<ApplicationGatewayPrivateEndpointConnection> privateEndpointConnections = default(IList<ApplicationGatewayPrivateEndpointConnection>), string resourceGuid = default(string), string provisioningState = default(string), IList<ApplicationGatewayCustomError> customErrorConfigurations = default(IList<ApplicationGatewayCustomError>), bool? forceFirewallPolicyAssociation = default(bool?), string etag = default(string), IList<string> zones = default(IList<string>), ManagedServiceIdentity identity = default(ManagedServiceIdentity)) | ||
| public ApplicationGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), ApplicationGatewaySku sku = default(ApplicationGatewaySku), ApplicationGatewaySslPolicy sslPolicy = default(ApplicationGatewaySslPolicy), string operationalState = default(string), IList<ApplicationGatewayIPConfiguration> gatewayIPConfigurations = default(IList<ApplicationGatewayIPConfiguration>), IList<ApplicationGatewayAuthenticationCertificate> authenticationCertificates = default(IList<ApplicationGatewayAuthenticationCertificate>), IList<ApplicationGatewayTrustedRootCertificate> trustedRootCertificates = default(IList<ApplicationGatewayTrustedRootCertificate>), IList<ApplicationGatewayTrustedClientCertificate> trustedClientCertificates = default(IList<ApplicationGatewayTrustedClientCertificate>), IList<ApplicationGatewaySslCertificate> sslCertificates = default(IList<ApplicationGatewaySslCertificate>), IList<ApplicationGatewayFrontendIPConfiguration> frontendIPConfigurations = default(IList<ApplicationGatewayFrontendIPConfiguration>), IList<ApplicationGatewayFrontendPort> frontendPorts = default(IList<ApplicationGatewayFrontendPort>), IList<ApplicationGatewayProbe> probes = default(IList<ApplicationGatewayProbe>), IList<ApplicationGatewayBackendAddressPool> backendAddressPools = default(IList<ApplicationGatewayBackendAddressPool>), IList<ApplicationGatewayBackendHttpSettings> backendHttpSettingsCollection = default(IList<ApplicationGatewayBackendHttpSettings>), IList<ApplicationGatewayHttpListener> httpListeners = default(IList<ApplicationGatewayHttpListener>), IList<ApplicationGatewaySslProfile> sslProfiles = default(IList<ApplicationGatewaySslProfile>), IList<ApplicationGatewayUrlPathMap> urlPathMaps = default(IList<ApplicationGatewayUrlPathMap>), IList<ApplicationGatewayRequestRoutingRule> requestRoutingRules = default(IList<ApplicationGatewayRequestRoutingRule>), IList<ApplicationGatewayRewriteRuleSet> rewriteRuleSets = default(IList<ApplicationGatewayRewriteRuleSet>), IList<ApplicationGatewayRedirectConfiguration> redirectConfigurations = default(IList<ApplicationGatewayRedirectConfiguration>), ApplicationGatewayWebApplicationFirewallConfiguration webApplicationFirewallConfiguration = default(ApplicationGatewayWebApplicationFirewallConfiguration), SubResource firewallPolicy = default(SubResource), bool? enableHttp2 = default(bool?), bool? enableFips = default(bool?), ApplicationGatewayAutoscaleConfiguration autoscaleConfiguration = default(ApplicationGatewayAutoscaleConfiguration), IList<ApplicationGatewayPrivateLinkConfiguration> privateLinkConfigurations = default(IList<ApplicationGatewayPrivateLinkConfiguration>), IList<ApplicationGatewayPrivateEndpointConnection> privateEndpointConnections = default(IList<ApplicationGatewayPrivateEndpointConnection>), string resourceGuid = default(string), string provisioningState = default(string), IList<ApplicationGatewayCustomError> customErrorConfigurations = default(IList<ApplicationGatewayCustomError>), bool? forceFirewallPolicyAssociation = default(bool?), IList<ApplicationGatewayLoadDistributionPolicy> loadDistributionPolicies = default(IList<ApplicationGatewayLoadDistributionPolicy>), ApplicationGatewayGlobalConfiguration globalConfiguration = default(ApplicationGatewayGlobalConfiguration), string etag = default(string), IList<string> zones = default(IList<string>), ManagedServiceIdentity identity = default(ManagedServiceIdentity)) |
There was a problem hiding this comment.
This method signature is changed. To prevent breaking customers code, you may want to provide a customization under https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/network/Microsoft.Azure.Management.Network/src/Customizations
You can refer to Compute to see how they customize the generated codes: https://github.com/Azure/azure-sdk-for-net/pull/23745/files#
archerzz
reviewed
Sep 3, 2021
| @@ -59,7 +61,7 @@ public ApplicationGatewayRequestRoutingRule() | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| /// <param name="type">Type of the resource.</param> | |||
| public ApplicationGatewayRequestRoutingRule(string id = default(string), string ruleType = default(string), int? priority = default(int?), SubResource backendAddressPool = default(SubResource), SubResource backendHttpSettings = default(SubResource), SubResource httpListener = default(SubResource), SubResource urlPathMap = default(SubResource), SubResource rewriteRuleSet = default(SubResource), SubResource redirectConfiguration = default(SubResource), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
| public ApplicationGatewayRequestRoutingRule(string id = default(string), string ruleType = default(string), int? priority = default(int?), SubResource backendAddressPool = default(SubResource), SubResource backendHttpSettings = default(SubResource), SubResource httpListener = default(SubResource), SubResource urlPathMap = default(SubResource), SubResource rewriteRuleSet = default(SubResource), SubResource redirectConfiguration = default(SubResource), SubResource loadDistributionPolicy = default(SubResource), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -55,13 +57,14 @@ public ApplicationGatewayUrlPathMap() | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| /// <param name="type">Type of the resource.</param> | |||
| public ApplicationGatewayUrlPathMap(string id = default(string), SubResource defaultBackendAddressPool = default(SubResource), SubResource defaultBackendHttpSettings = default(SubResource), SubResource defaultRewriteRuleSet = default(SubResource), SubResource defaultRedirectConfiguration = default(SubResource), IList<ApplicationGatewayPathRule> pathRules = default(IList<ApplicationGatewayPathRule>), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
| public ApplicationGatewayUrlPathMap(string id = default(string), SubResource defaultBackendAddressPool = default(SubResource), SubResource defaultBackendHttpSettings = default(SubResource), SubResource defaultRewriteRuleSet = default(SubResource), SubResource defaultRedirectConfiguration = default(SubResource), SubResource defaultLoadDistributionPolicy = default(SubResource), IList<ApplicationGatewayPathRule> pathRules = default(IList<ApplicationGatewayPathRule>), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| /// <param name="sku">The sku of this Bastion Host.</param> | ||
| public BastionHost(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<BastionHostIPConfiguration> ipConfigurations = default(IList<BastionHostIPConfiguration>), string dnsName = default(string), string provisioningState = default(string), string etag = default(string), Sku sku = default(Sku)) | ||
| public BastionHost(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<BastionHostIPConfiguration> ipConfigurations = default(IList<BastionHostIPConfiguration>), string dnsName = default(string), string provisioningState = default(string), int? scaleUnits = default(int?), bool? disableCopyPaste = default(bool?), bool? enableFileCopy = default(bool?), bool? enableIpConnect = default(bool?), bool? enableShareableLink = default(bool?), bool? enableTunneling = default(bool?), string etag = default(string), Sku sku = default(Sku)) |
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -45,11 +47,12 @@ public BgpConnection() | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| /// <param name="type">Connection type.</param> | |||
| public BgpConnection(string id = default(string), long? peerAsn = default(long?), string peerIp = default(string), string provisioningState = default(string), string connectionState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
| public BgpConnection(string id = default(string), long? peerAsn = default(long?), string peerIp = default(string), SubResource hubVirtualNetworkConnection = default(SubResource), string provisioningState = default(string), string connectionState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -60,7 +63,7 @@ public DscpConfiguration() | |||
| /// 'Updating', 'Deleting', 'Failed'</param> | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| public DscpConfiguration(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<int?> markings = default(IList<int?>), IList<QosIpRange> sourceIpRanges = default(IList<QosIpRange>), IList<QosIpRange> destinationIpRanges = default(IList<QosIpRange>), IList<QosPortRange> sourcePortRanges = default(IList<QosPortRange>), IList<QosPortRange> destinationPortRanges = default(IList<QosPortRange>), string protocol = default(string), string qosCollectionId = default(string), IList<NetworkInterface> associatedNetworkInterfaces = default(IList<NetworkInterface>), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string)) | |||
| public DscpConfiguration(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<int?> markings = default(IList<int?>), IList<QosIpRange> sourceIpRanges = default(IList<QosIpRange>), IList<QosIpRange> destinationIpRanges = default(IList<QosIpRange>), IList<QosPortRange> sourcePortRanges = default(IList<QosPortRange>), IList<QosPortRange> destinationPortRanges = default(IList<QosPortRange>), string protocol = default(string), IList<QosDefinition> qosDefinitionCollection = default(IList<QosDefinition>), string qosCollectionId = default(string), IList<NetworkInterface> associatedNetworkInterfaces = default(IList<NetworkInterface>), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -67,7 +70,7 @@ public FirewallPolicy() | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| /// <param name="identity">The identity of the firewall policy.</param> | |||
| public FirewallPolicy(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResource> ruleCollectionGroups = default(IList<SubResource>), string provisioningState = default(string), SubResource basePolicy = default(SubResource), IList<SubResource> firewalls = default(IList<SubResource>), IList<SubResource> childPolicies = default(IList<SubResource>), string threatIntelMode = default(string), FirewallPolicyThreatIntelWhitelist threatIntelWhitelist = default(FirewallPolicyThreatIntelWhitelist), FirewallPolicyInsights insights = default(FirewallPolicyInsights), FirewallPolicySNAT snat = default(FirewallPolicySNAT), DnsSettings dnsSettings = default(DnsSettings), FirewallPolicyIntrusionDetection intrusionDetection = default(FirewallPolicyIntrusionDetection), FirewallPolicyTransportSecurity transportSecurity = default(FirewallPolicyTransportSecurity), FirewallPolicySku sku = default(FirewallPolicySku), string etag = default(string), ManagedServiceIdentity identity = default(ManagedServiceIdentity)) | |||
| public FirewallPolicy(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResource> ruleCollectionGroups = default(IList<SubResource>), string provisioningState = default(string), SubResource basePolicy = default(SubResource), IList<SubResource> firewalls = default(IList<SubResource>), IList<SubResource> childPolicies = default(IList<SubResource>), string threatIntelMode = default(string), FirewallPolicyThreatIntelWhitelist threatIntelWhitelist = default(FirewallPolicyThreatIntelWhitelist), FirewallPolicyInsights insights = default(FirewallPolicyInsights), FirewallPolicySNAT snat = default(FirewallPolicySNAT), FirewallPolicySQL sql = default(FirewallPolicySQL), DnsSettings dnsSettings = default(DnsSettings), ExplicitProxySettings explicitProxySettings = default(ExplicitProxySettings), FirewallPolicyIntrusionDetection intrusionDetection = default(FirewallPolicyIntrusionDetection), FirewallPolicyTransportSecurity transportSecurity = default(FirewallPolicyTransportSecurity), FirewallPolicySku sku = default(FirewallPolicySku), string etag = default(string), ManagedServiceIdentity identity = default(ManagedServiceIdentity)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -68,7 +82,7 @@ public InboundNatRule() | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| /// <param name="type">Type of the resource.</param> | |||
| public InboundNatRule(string id = default(string), SubResource frontendIPConfiguration = default(SubResource), NetworkInterfaceIPConfiguration backendIPConfiguration = default(NetworkInterfaceIPConfiguration), string protocol = default(string), int? frontendPort = default(int?), int? backendPort = default(int?), int? idleTimeoutInMinutes = default(int?), bool? enableFloatingIP = default(bool?), bool? enableTcpReset = default(bool?), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
| public InboundNatRule(string id = default(string), SubResource frontendIPConfiguration = default(SubResource), NetworkInterfaceIPConfiguration backendIPConfiguration = default(NetworkInterfaceIPConfiguration), string protocol = default(string), int? frontendPort = default(int?), int? backendPort = default(int?), int? idleTimeoutInMinutes = default(int?), bool? enableFloatingIP = default(bool?), bool? enableTcpReset = default(bool?), int? frontendPortRangeStart = default(int?), int? frontendPortRangeEnd = default(int?), SubResource backendAddressPool = default(SubResource), string provisioningState = default(string), string name = default(string), string etag = default(string), string type = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| @@ -65,7 +66,7 @@ public NetworkVirtualAppliance() | |||
| /// to cloud-init and config blob.</param> | |||
| /// <param name="etag">A unique read-only string that changes whenever | |||
| /// the resource is updated.</param> | |||
| public NetworkVirtualAppliance(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), VirtualApplianceSkuProperties nvaSku = default(VirtualApplianceSkuProperties), string addressPrefix = default(string), IList<string> bootStrapConfigurationBlobs = default(IList<string>), SubResource virtualHub = default(SubResource), IList<string> cloudInitConfigurationBlobs = default(IList<string>), string cloudInitConfiguration = default(string), long? virtualApplianceAsn = default(long?), IList<VirtualApplianceNicProperties> virtualApplianceNics = default(IList<VirtualApplianceNicProperties>), IList<SubResource> virtualApplianceSites = default(IList<SubResource>), IList<SubResource> inboundSecurityRules = default(IList<SubResource>), string provisioningState = default(string), ManagedServiceIdentity identity = default(ManagedServiceIdentity), string etag = default(string)) | |||
| public NetworkVirtualAppliance(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), VirtualApplianceSkuProperties nvaSku = default(VirtualApplianceSkuProperties), string addressPrefix = default(string), IList<string> bootStrapConfigurationBlobs = default(IList<string>), SubResource virtualHub = default(SubResource), IList<string> cloudInitConfigurationBlobs = default(IList<string>), string cloudInitConfiguration = default(string), long? virtualApplianceAsn = default(long?), string sshPublicKey = default(string), IList<VirtualApplianceNicProperties> virtualApplianceNics = default(IList<VirtualApplianceNicProperties>), IList<SubResource> virtualApplianceSites = default(IList<SubResource>), IList<SubResource> inboundSecurityRules = default(IList<SubResource>), string provisioningState = default(string), ManagedServiceIdentity identity = default(ManagedServiceIdentity), string etag = default(string)) | |||
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| public PrivateEndpoint(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), ExtendedLocation extendedLocation = default(ExtendedLocation), Subnet subnet = default(Subnet), IList<NetworkInterface> networkInterfaces = default(IList<NetworkInterface>), string provisioningState = default(string), IList<PrivateLinkServiceConnection> privateLinkServiceConnections = default(IList<PrivateLinkServiceConnection>), IList<PrivateLinkServiceConnection> manualPrivateLinkServiceConnections = default(IList<PrivateLinkServiceConnection>), IList<CustomDnsConfigPropertiesFormat> customDnsConfigs = default(IList<CustomDnsConfigPropertiesFormat>), string etag = default(string)) | ||
| public PrivateEndpoint(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), ExtendedLocation extendedLocation = default(ExtendedLocation), Subnet subnet = default(Subnet), IList<NetworkInterface> networkInterfaces = default(IList<NetworkInterface>), string provisioningState = default(string), IList<PrivateLinkServiceConnection> privateLinkServiceConnections = default(IList<PrivateLinkServiceConnection>), IList<PrivateLinkServiceConnection> manualPrivateLinkServiceConnections = default(IList<PrivateLinkServiceConnection>), IList<CustomDnsConfigPropertiesFormat> customDnsConfigs = default(IList<CustomDnsConfigPropertiesFormat>), IList<ApplicationSecurityGroup> applicationSecurityGroups = default(IList<ApplicationSecurityGroup>), IList<PrivateEndpointIPConfiguration> ipConfigurations = default(IList<PrivateEndpointIPConfiguration>), string customNetworkInterfaceName = default(string), string etag = default(string)) |
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| /// <param name="kind">Kind of service endpoint policy. This is | ||
| /// metadata used for the Azure portal experience.</param> | ||
| public ServiceEndpointPolicy(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<ServiceEndpointPolicyDefinition> serviceEndpointPolicyDefinitions = default(IList<ServiceEndpointPolicyDefinition>), IList<Subnet> subnets = default(IList<Subnet>), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string), string kind = default(string)) | ||
| public ServiceEndpointPolicy(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<ServiceEndpointPolicyDefinition> serviceEndpointPolicyDefinitions = default(IList<ServiceEndpointPolicyDefinition>), IList<Subnet> subnets = default(IList<Subnet>), string resourceGuid = default(string), string provisioningState = default(string), string serviceAlias = default(string), IList<string> contextualServiceEndpointPolicies = default(IList<string>), string etag = default(string), string kind = default(string)) |
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
reviewed
Sep 3, 2021
...k/Microsoft.Azure.Management.Network/src/Generated/Models/ServiceEndpointPolicyDefinition.cs
Show resolved
Hide resolved
archerzz
reviewed
Sep 3, 2021
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ServiceTagInformation.cs
Show resolved
Hide resolved
archerzz
reviewed
Sep 3, 2021
| /// <param name="isRoutingPreferenceInternet">Enable Routing Preference | ||
| /// property for the Public IP Interface of the VpnGateway.</param> | ||
| /// <param name="natRules">List of all the nat Rules associated with | ||
| /// the gateway.</param> | ||
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| public VpnGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), SubResource virtualHub = default(SubResource), IList<VpnConnection> connections = default(IList<VpnConnection>), BgpSettings bgpSettings = default(BgpSettings), string provisioningState = default(string), int? vpnGatewayScaleUnit = default(int?), IList<VpnGatewayIpConfiguration> ipConfigurations = default(IList<VpnGatewayIpConfiguration>), bool? isRoutingPreferenceInternet = default(bool?), IList<VpnGatewayNatRule> natRules = default(IList<VpnGatewayNatRule>), string etag = default(string)) | ||
| public VpnGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), SubResource virtualHub = default(SubResource), IList<VpnConnection> connections = default(IList<VpnConnection>), BgpSettings bgpSettings = default(BgpSettings), string provisioningState = default(string), int? vpnGatewayScaleUnit = default(int?), IList<VpnGatewayIpConfiguration> ipConfigurations = default(IList<VpnGatewayIpConfiguration>), bool? enableBgpRouteTranslationForNat = default(bool?), bool? isRoutingPreferenceInternet = default(bool?), IList<VpnGatewayNatRule> natRules = default(IList<VpnGatewayNatRule>), string etag = default(string)) |
There was a problem hiding this comment.
Provide customization to keep the original method signature.
archerzz
suggested changes
Sep 3, 2021
archerzz
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
@MikhailTryakhov The breaking changes are all in the models, which should be OK.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:Mitryakh/network march azure-rest-api-specs#15709
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.