Updated tests for changes in PR https://github.com/Azure/azure-rest-api-specs/pull/18609 #28063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)
D1v38om83r
requested review from
m-nash,
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
ghost
added
the
…roup, but unrelated to my Swagger changes
|
SDK generated from Azure/azure-rest-api-specs@f830443 |
…rce-management.txt file that were created by SDK generation.
grizzlytheodore
suggested changes
Apr 18, 2022
| : base(targetRegions, replicaCount, excludeFromLatest, publishedDate, endOfLifeDate, storageAccountType, replicationMode, targetExtendedLocations) | ||
| { | ||
| Source = source; | ||
| ManageActions = manageActions; | ||
| Settings = settings; |
There was a problem hiding this comment.
customization needed - for theo
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/SdkInfo_ComputeManagementClient.cs
Outdated
Show resolved
Hide resolved
…enerated\SdkInfo_ComputeManagementClient.cs
…zure-sdk-for-net into dev/bhbrahma/cplat-2022-03-01
grizzlytheodore
added a commit
that referenced
this pull request
May 10, 2022
) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]>
Yao725
pushed a commit
that referenced
this pull request
May 13, 2022
* generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (#28006) * [RestorePoints] InstanceView Fix SDK changes (#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (#28006) * [RestorePoints] InstanceView Fix SDK changes (#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * without preview release * Delete VMApplicationProfile_Tests.json * Delete TestVMScaleSetApplicationProfile.json * fix VMTestBase for DH * resolve tests * update version name * Sanitize SAS and key * Update Microsoft.Azure.Management.Compute.csproj Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: prchin <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Bhaskar Brahma <[email protected]>
paterasMSFT
pushed a commit
that referenced
this pull request
Jun 15, 2022
* generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (#28006) * [RestorePoints] InstanceView Fix SDK changes (#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (#28006) * [RestorePoints] InstanceView Fix SDK changes (#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * without preview release * Delete VMApplicationProfile_Tests.json * Delete TestVMScaleSetApplicationProfile.json * fix VMTestBase for DH * resolve tests * update version name * Sanitize SAS and key * Update Microsoft.Azure.Management.Compute.csproj Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: prchin <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Bhaskar Brahma <[email protected]>
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
* generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (Azure#28006) * [RestorePoints] InstanceView Fix SDK changes (Azure#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (Azure#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * generated from new folder * fix updateed object * updated recordings for 2022-03-01 * new recordings * last recordings and test fixes * fix dedicated host test * add ; * mitigate failing test * fix last test recording * Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984) * generated * updated code Co-authored-by: Theodore Chang <[email protected]> * update with latest swagger form * dedicatedHost customization * small ssdk change 1.1 (Azure#28006) * [RestorePoints] InstanceView Fix SDK changes (Azure#28188) * sdk changes for instanview fix 1.1 * added record tests 2.1 Co-authored-by: Theodore Chang <[email protected]> * SDK changes for Vmss Flex deleteOption (Azure#27923) * delete option vmss flex * record test * newline * regenerated sdk Co-authored-by: Kimberly Yip Chang <[email protected]> * Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063) * Generated SDK * added tests, playback recordings for VM and VMSS application profile (cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89) * Fixed and re-recoded galley application and gallery application version tests * Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes * added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation. * Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt * Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs * Re-created the SDK withhout changes to gallery.json and undid changes to test. * Added test recordings for VM and VMSS application profile. * remove changes from tests that were not re-recorded Co-authored-by: Theodore Chang <[email protected]> * without preview release * Delete VMApplicationProfile_Tests.json * Delete TestVMScaleSetApplicationProfile.json * fix VMTestBase for DH * resolve tests * update version name * Sanitize SAS and key * Update Microsoft.Azure.Management.Compute.csproj Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: prchin <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Kimberly Yip Chang <[email protected]> Co-authored-by: Bhaskar Brahma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.