Skip to content

SDK Release for desktopvirtualization based on 2022-09-09 api (latest stable) #35258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 11, 2023
Merged

SDK Release for desktopvirtualization based on 2022-09-09 api (latest stable) #35258

merged 8 commits into from
May 11, 2023

Conversation

alec-baird
Copy link
Member

…ice with tag package-2022-09 (latest stable)

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@alec-baird
Ran GenerateCode, Tests, and Export-API on desktopvirtualization serv…
88f2e51 
…ice with tag package-2022-09 (latest stable)
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 30, 2023
@github-actions
Copy link

Thank you for your contribution @alec-baird! We will review the pull request and get back to you soon.

@alec-baird
Copy link
Member Author

@JeffreyRichter , as you approved our stable with the breaking changes, can you provide context on how we can get the SDK released with the breaking changes?

@JeffreyRichter
Copy link
Member

@JeffreyRichter , as you approved our stable with the breaking changes, can you provide context on how we can get the SDK released with the breaking changes?

Do you have a link to the swagger PR where the breaking changes were made?

@alec-baird
Copy link
Member Author

@JeffreyRichter , as you approved our stable with the breaking changes, can you provide context on how we can get the SDK released with the breaking changes?

Do you have a link to the swagger PR where the breaking changes were made?

Azure/azure-rest-api-specs#20683

@JeffreyRichter
Copy link
Member

@ArthurMa1978, The Azure Breaking Change review board approved the swagger breaks that are causing these SDK breaks (I think). Since this is a control plane SDK, that is code gen'd, the back compat issues can't be fixed unless the .NET SDK team expects these to be manually fixed. What is the .NET SDK team's expectation here?

@ArthurMa1978 ArthurMa1978 mentioned this pull request Apr 17, 2023
Closed
@alec-baird
Copy link
Member Author

@ArthurMa1978 , it has been 2 weeks since we have last heard anything on this PR. Can you take a look?

@ArthurMa1978
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
badf5c5 
…o alecb/20220909sdkrelease

# Conflicts:
#	sdk/desktopvirtualization/Azure.ResourceManager.DesktopVirtualization/src/Generated/Extensions/DesktopVirtualizationExtensions.cs
#	sdk/desktopvirtualization/Azure.ResourceManager.DesktopVirtualization/src/Generated/Models/DesktopVirtualizationMigrationProperties.Serialization.cs
#	sdk/desktopvirtualization/Azure.ResourceManager.DesktopVirtualization/src/Generated/Models/VirtualApplicationGroupData.Serialization.cs
@ArthurMa1978
Fixed all breaking changes
ee3cf78
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.DesktopVirtualization

@ArthurMa1978 ArthurMa1978 merged commit 9a44bfb into Azure:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@archerzz archerzz Awaiting requested review from archerzz

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

Assignees

@m-nash m-nash

Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alec-baird @JeffreyRichter @azure-sdk @ArthurMa1978 @m-nash