Create Virtual Enclaves SDK #51940
Create Virtual Enclaves SDK #51940
Conversation
jchavaherrera
requested review from
ArcturusZhang,
ArthurMa1978 and
jsquire
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR creates a new Azure SDK for Virtual Enclaves management operations. The SDK follows Azure Resource Manager patterns and provides .NET bindings for managing Virtual Enclaves resources in Azure.
Key changes include:
- Initial project structure and configuration files for the Virtual Enclaves SDK
- Standard Azure SDK documentation and project setup
- Sample and test project scaffolding
Reviewed Changes
Copilot reviewed 7 out of 245 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Azure.ResourceManager.VirtualEnclaves.csproj | Main SDK project file with package metadata and version information |
| samples/Azure.ResourceManager.VirtualEnclaves.Samples.csproj | Sample project configuration with necessary dependencies |
| assets.json | Asset repository configuration for SDK assets management |
| README.md | Comprehensive documentation with usage examples and getting started guide |
| Directory.Build.props | MSBuild properties configuration for the package |
| CHANGELOG.md | Release history documentation for version 1.0.0-beta.1 |
| Azure.ResourceManager.VirtualEnclaves.sln | Visual Studio solution file containing all projects |
sdk/virtualenclaves/Azure.ResourceManager.VirtualEnclaves/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Your account lacks the public memberships to the Microsoft and Azure GitHub organizations required of an internal contributor. Any memberships that you currently hold for these organizations are marked as private. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
…ME.md Co-authored-by: Copilot <[email protected]>
@jsquire: Let me know if more changes are needed |
|
@jchavaherrera: Account changes look good. You'll need to engage @ronniegeraghty to discuss a service label, as those are centrally managed. |
@jsquire Got it! in the meantime I removed the service label and I'll talk to him about it. Thanks! |
| @@ -918,6 +918,9 @@ | |||
| # ServiceLabel: %VideoAnalyzer | |||
| # ServiceOwners: @giakas | |||
|
|
|||
| # ServiceLabel: %VirtualEnclaves | |||
There was a problem hiding this comment.
After you have a valid label, this will need to move into the management section that starts on L955 and include %Mgmt. Entries should be ordered alphabetically by label name.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.