Migrate SystemEvents library to new generator #51945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o eg-se-migration-aug
…o eg-se-migration-aug
…o eg-se-migration-aug
…o eg-se-migration-aug
JoshLove-msft
requested review from
Kishp01,
shankarsama and
rajeshka
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the SystemEvents library to a new generator, updating various code generation attributes and modernizing the codebase. The changes primarily involve updating deprecated attributes, removing unused imports, and adjusting API calls to match the new generator's patterns.
Key changes:
- Updates code generation attributes from
CodeGenModeltoCodeGenType - Adds
ModelSerializationExtensions.WireOptionsparameter to deserialization calls - Removes unused imports and auto-generated file headers
Reviewed Changes
Copilot reviewed 31 out of 654 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| UnknownMediaJobOutput.Serialization.cs | Removes auto-generated header and nullable disable directive |
| StampKind.cs | Updates CodeGenModel attribute to CodeGenType |
| Multiple Resource*EventData.cs files | Adds WireOptions parameter to deserialization calls |
| EventGridMqttClientDisconnectionReason.cs | Fixes property name reference from IPForbiddenValue to IpForbiddenValue |
| EventGridModelFactory.cs | Updates type name and adds CodeGenSuppress attributes, removes parameter |
| Multiple other customization files | Updates CodeGenModel to CodeGenType and removes unused imports |
| AcsRouterJobEventData.cs | New file adding Labels and Tags properties |
| Azure.Messaging.EventGrid.SystemEvents.csproj | Updates version to 1.1.0-beta.1 and adds configuration |
| CHANGELOG.md | Adds new version section |
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Customization/EventGridModelFactory.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Generated/EventGridModelFactory.cs
Outdated
Show resolved
Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid.SystemEvents/src/Generated/EventGridModelFactory.cs
Outdated
Show resolved
Hide resolved
jorgerangel-msft
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51237