Minor fixers for Azure.Provisioning.Dns #54212
Open
+27
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly focusing on A, AAAA, TXT and CName records. * `DnsARecord`: `Ipv4Addresses` to `Ipv4Address`. Something similar to DnsAaaaRecordInfo. * using `nameof` instead of the properties names as strings. * `DnsCnameRecord.Cname` was not being backed by the `.properties.CNAMERecord.cname`. Fixed.
tmacam
requested review from
ArcturusZhang,
ArthurMa1978 and
m-nash
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @tmacam! We will review the pull request and get back to you soon. |
Copilot finished reviewing on behalf of
tmacam
November 29, 2025 03:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves consistency and correctness in the Azure.Provisioning.Dns library by renaming properties, adopting the nameof operator, and fixing property path mappings.
- Renamed
Ipv4AddressestoIpv4AddressinDnsARecordInfoandIpv6AddressestoIpv6AddressinDnsAaaaRecordInfoto better reflect that each info object holds a single IP address - Replaced string literals with
nameofoperator for type-safe property references inDnsARecord,DnsTxtRecord, andDnsCnameRecord - Fixed the property path mapping for
DnsCnameRecord.Cnameto correctly point to["properties", "cname"]
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/provisioning/Azure.Provisioning.Dns/src/Models/DnsAaaaRecordInfo.cs | Renamed property from Ipv6Addresses to Ipv6Address and updated backing field references |
| sdk/provisioning/Azure.Provisioning.Dns/src/Models/DnsARecordInfo.cs | Renamed property from Ipv4Addresses to Ipv4Address, updated backing field references, and adopted nameof operator |
| sdk/provisioning/Azure.Provisioning.Dns/src/DnsTxtRecord.cs | Replaced string literals with nameof operator for all property definitions |
| sdk/provisioning/Azure.Provisioning.Dns/src/DnsCnameRecord.cs | Replaced string literals with nameof operator and fixed property path from ["CNAMERecord", "cname"] to ["properties", "cname"] |
| sdk/provisioning/Azure.Provisioning.Dns/src/DnsARecord.cs | Replaced string literals with nameof operator for all property definitions |
| sdk/provisioning/Azure.Provisioning.Dns/README.md | Updated code example to use the new Ipv4Address property name |
| { | ||
| base.DefineProvisionableProperties(); | ||
| _ipv6Addresses = DefineProperty<IPAddress>("IPv6Addresses", ["ipv6Addresses"]); | ||
| _ipv6Address = DefineProperty<IPAddress>("IPv6Address", ["ipv6Address"]); |
There was a problem hiding this comment.
Inconsistent use of nameof operator. While DnsARecordInfo uses nameof(Ipv4Address) for consistency, this file still uses the string literal "IPv6Address". For consistency, this should be nameof(Ipv6Address) to match the pattern used in DnsARecordInfo.cs.
Suggested change
| _ipv6Address = DefineProperty<IPAddress>("IPv6Address", ["ipv6Address"]); | |
| _ipv6Address = DefineProperty<IPAddress>(nameof(Ipv6Address), ["ipv6Address"]); |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly focusing on A, AAAA, TXT and CName records.
DnsARecord:Ipv4AddressestoIpv4Address. Something similar onDnsAaaaRecord.nameofinstead of the properties names as strings.DnsCnameRecord.Cnamewas not being backed by the.properties.CNAMERecord.cname. Fixed.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.