Skip to content

Fix sample links in Evaluation README #38643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mccoyp merged 1 commit into from
Nov 23, 2024
Merged

Fix sample links in Evaluation README #38643

mccoyp merged 1 commit into from
Nov 23, 2024

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Nov 21, 2024

Description

This updates links to samples, to account for reorganization done in Azure-Samples/azureai-samples#153, and resolves failures in our nightly link checker.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Client This issue points to a problem in the data-plane of the library. Evaluation Issues related to the client library for Azure AI Evaluation labels Nov 21, 2024
@mccoyp mccoyp requested a review from a team as a code owner November 21, 2024 19:50
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 21, 2024

API change check

API changes are not detected in this pull request.

@mccoyp mccoyp merged commit 7a138a8 into Azure:main Nov 23, 2024
34 checks passed
@mccoyp mccoyp deleted the evaluation-broken-links branch November 23, 2024 01:00
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@mccoyp @l0lawrence
Fix sample links in Evaluation (Azure#38643)
ca909ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@nagkumar91 nagkumar91 Awaiting requested review from nagkumar91

@singankit singankit Awaiting requested review from singankit

@ninghu ninghu Awaiting requested review from ninghu

1 more reviewer

@kristapratico kristapratico kristapratico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mccoyp @azure-sdk @kristapratico