[OPS Common SDK] Update Communication Common SDK for Teams Phone Extensibility GA #41219
Merged
kristapratico merged 108 commits intomainfrom Jun 19, 2025
Merged
[OPS Common SDK] Update Communication Common SDK for Teams Phone Extensibility GA #41219kristapratico merged 108 commits intomainfrom
kristapratico merged 108 commits intomainfrom
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews azure-communication-identity |
cemateia
commented
May 22, 2025
sdk/communication/azure-communication-identity/tests/test_identifier_raw_id.py
Outdated
Show resolved
Hide resolved
cemateia
commented
May 22, 2025
sdk/communication/azure-communication-identity/azure/communication/identity/_shared/models.py
Outdated
Show resolved
Hide resolved
cemateia
commented
May 26, 2025
...e-communication-identity/azure/communication/identity/_shared/entra_user_credential_async.py
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
...nication/azure-communication-identity/azure/communication/identity/_shared/token_exchange.py
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
sdk/communication/azure-communication-identity/tests/test_token_exchange_utils.py
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
sdk/communication/azure-communication-identity/tests/test_token_exchange_utils.py
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
sdk/communication/azure-communication-identity/tests/test_user_credential.py
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
sdk/communication/azure-communication-identity/tests/test_user_credential.py
Show resolved
Hide resolved
AikoBB
reviewed
Jun 17, 2025
Member
AikoBB
left a comment
AikoBB
left a comment
There was a problem hiding this comment.
let's focus on the sdk comments, and we can create a follow up PR for the test comments
AikoBB
approved these changes
Jun 18, 2025
Member
AikoBB
left a comment
AikoBB
left a comment
There was a problem hiding this comment.
lgtm, just two comments we can fix in upcoming PRs
...on/azure-communication-identity/azure/communication/identity/_shared/token_exchange_async.py
Outdated
Show resolved
Hide resolved
...n/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py
Outdated
Show resolved
Hide resolved
AikoBB
approved these changes
Jun 18, 2025
...ication/azure-communication-messages/azure/communication/messages/_shared/user_credential.py
Outdated
Show resolved
Hide resolved
...unication-callautomation/azure/communication/callautomation/_shared/user_credential_async.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/check-enforcer override |
kristapratico
approved these changes
Jun 19, 2025
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Analyze failures tracked and will be fixed in another PR
v-dharmarajv
pushed a commit
that referenced
this pull request
Jul 1, 2025
…nsibility GA (#41219) * Update models.py * Update models.py * Update models.py * Update phone number identifier * add tests * small updates * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * Create entra_user_credential_async.py * add entra token cred * add async exchange * Update models.py * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * update credential * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Create pipeline_utils.py * Create entra_token_guard_policy.py * Create entra_token_credential_options.py * Create token_exchange.py * Update token_exchange.py * updates * Update token_exchange.py * Update token_exchange.py * cleanup old files * Update token_exchange.py * Update entra_token_guard_policy.py * updated credential classes * updates * Delete manual_test.py * Update user_credential.py * Copy to all _shared in all sdks * Update sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_shared/entra_token_guard_policy.py Co-authored-by: Dominik <dominik.messinger@gmail.com> * Update token_exchange.py * update version * Fix imports * Fix imports in all folders * Fix test * Update test_identifier_raw_id.py * Update dev_requirements.txt * try to fix conflict in pipeline * try to fix conflict in pipeline 2 * Update setup.py * try to fix call automation * remove references * expose the identifiers * Update documentation for credential to include the optional params * Delete manual_test.py * Update _version.py * fix comment to default the cloud * fix comments for phone number properties * fix path * Update CHANGELOG.md * fix cloud param * fix comment * Create test_entra_token_guard_policy.py * fix for cloud param * Add tests for token exchange * add tests for credential * update test * Update test_user_credential_async.py * add check in async cred * fix cloud * update not required * Update test_identifier_raw_id.py * fix passing scopes * copy paste from identity * fix space * fix sending scopes * Update test_token_exchange.py * fix spaces for doc * fix pylint errors * fix pylint error in model * fix props in phone number * fix dateutil import * update init of asserted_id * replace none with "" * update models phone number * fix some pylint errors: format * split files * pylint fixes * pylint call automation * pylint for all * fix some pylint warnings * fix last warnings in identity * update all * update token exchange * update credential for all sdks * fix comments * add some tests * fix tests * fix some comments * fix comments * copy in all sdks * fix include * fix import * fix tests * fix comments * fix analysis warnings * fix mypy * fix pylint * fix mypy * fix optional scopes --------- Co-authored-by: Dominik <dominik.messinger@gmail.com>
annatisch
added a commit
that referenced
this pull request
Jul 30, 2025
* updating ga5 version * Addressing comments * fixing the media streaming error * updating the change * Recorded live tests + GA5 changes (#41253) * updating the locale and adding the operation callback uril in the unholdoptions * updating hold operationcallback url * updating version number * adding the dtmf * fixing the spelling error on the comment * Live/Recorded Tests (#41328) * Rerecorded live tests. * Pushed assets.json. * fixing the pipeline error * fixing lint error * fixing the recording issue * fixing doc error * Created feature branch off of callautomation/release/ga5. Updated to ga6 apispec and made necessary changes. * Made changes to start recording to effectively handle call_connection_id to locate call rather than using call locator. * Recorded live tests for ga6. * updating changelog * [OPS Common SDK] Update Communication Common SDK for Teams Phone Extensibility GA (#41219) * Update models.py * Update models.py * Update models.py * Update phone number identifier * add tests * small updates * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * Create entra_user_credential_async.py * add entra token cred * add async exchange * Update models.py * Update test_identifier_raw_id.py * Update test_identifier_raw_id.py * update credential * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Update entra_user_credential_async.py * Create pipeline_utils.py * Create entra_token_guard_policy.py * Create entra_token_credential_options.py * Create token_exchange.py * Update token_exchange.py * updates * Update token_exchange.py * Update token_exchange.py * cleanup old files * Update token_exchange.py * Update entra_token_guard_policy.py * updated credential classes * updates * Delete manual_test.py * Update user_credential.py * Copy to all _shared in all sdks * Update sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_shared/entra_token_guard_policy.py Co-authored-by: Dominik <dominik.messinger@gmail.com> * Update token_exchange.py * update version * Fix imports * Fix imports in all folders * Fix test * Update test_identifier_raw_id.py * Update dev_requirements.txt * try to fix conflict in pipeline * try to fix conflict in pipeline 2 * Update setup.py * try to fix call automation * remove references * expose the identifiers * Update documentation for credential to include the optional params * Delete manual_test.py * Update _version.py * fix comment to default the cloud * fix comments for phone number properties * fix path * Update CHANGELOG.md * fix cloud param * fix comment * Create test_entra_token_guard_policy.py * fix for cloud param * Add tests for token exchange * add tests for credential * update test * Update test_user_credential_async.py * add check in async cred * fix cloud * update not required * Update test_identifier_raw_id.py * fix passing scopes * copy paste from identity * fix space * fix sending scopes * Update test_token_exchange.py * fix spaces for doc * fix pylint errors * fix pylint error in model * fix props in phone number * fix dateutil import * update init of asserted_id * replace none with "" * update models phone number * fix some pylint errors: format * split files * pylint fixes * pylint call automation * pylint for all * fix some pylint warnings * fix last warnings in identity * update all * update token exchange * update credential for all sdks * fix comments * add some tests * fix tests * fix some comments * fix comments * copy in all sdks * fix include * fix import * fix tests * fix comments * fix analysis warnings * fix mypy * fix pylint * fix mypy * fix optional scopes --------- Co-authored-by: Dominik <dominik.messinger@gmail.com> * updating api version * ga6 vesrion update * updating the python version * updating the live test * pushing resolve issue * changelog update * Update serialization.py * updating ordering * changing to dev version number as the pipeline is not letting to create the PR succeeded * version number update * Adding the classifier for the ga release * making the teams extension users constructers to have the keyword only param * copy issue fixing * spell check fix * updating communication shared code to use the isodate instead of the … (#42085) * udpating communication shared code to use the isodate instead of the date util * fixing the tests * fix the test failure * Updated communications dependencies * Local transport import statements * Use fixed offsets instead of ZoneInfo to fix tests in all environments * addressing the comments * changing to zoneinfo as per the comments * Revert "changing to zoneinfo as per the comments" This reverts commit 3e2610d. --------- Co-authored-by: antisch <antisch@microsoft.com> Co-authored-by: Cezara Mateiasi <CEMATEIA@microsoft.com> * release date update * update changelog * Add asynchronous tests to align with existing synchronous tests in Call Automation SDK (#41990) * Creating async live tests for call automation * Removing the unavailable tests for GA6 * Updating the async tests for call automation * updating the changes * Pushing the recorded tests and assests.json * updating the async tests * Adding the async tests for callautomation * updating asset file --------- Co-authored-by: Vinothini Dharmaraj <v-dharmarajv@microsoft.com> * fixing the long path issue fixed for the build failure * removing older files * removing the release * reverting the version beta to check in changes to main as the release date is not confirmed * reverting classifier --------- Co-authored-by: v-saasomani <v-saasomani@microsoft.com> Co-authored-by: Cezara Zamfir <66410283+cemateia@users.noreply.github.com> Co-authored-by: Dominik <dominik.messinger@gmail.com> Co-authored-by: antisch <antisch@microsoft.com> Co-authored-by: Cezara Mateiasi <CEMATEIA@microsoft.com> Co-authored-by: Srinivasa Kaluri <v-vkaluri@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Communication Common SDK for Teams Phone Extensibility GA
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines