[WebPubSubClient] Convert azure-messaging-webpubsubclient package from setup.py to pyproject.toml with Python 3.9+ support #42462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: swathipil <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
swathipil
August 11, 2025 18:51
swathipil
reviewed
Aug 11, 2025
…in readme, and add doc*/stress* exclusions Co-authored-by: swathipil <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
swathipil
August 11, 2025 21:40
swathipil
reviewed
Aug 11, 2025
Co-authored-by: swathipil <[email protected]>
Copilot finished work on behalf of
swathipil
August 11, 2025 22:17
swathipil
reviewed
Aug 12, 2025
Co-authored-by: swathipil <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the azure-messaging-webpubsubclient package by migrating from the legacy setup.py configuration to the modern pyproject.toml format, aligning with current Python packaging standards and Azure SDK guidelines.
Key changes:
- Complete migration from
setup.pytopyproject.tomlwith all package metadata preserved - Dynamic version loading configuration pointing to the correct module path
- Proper build system and package discovery setup with namespace package exclusions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Complete removal of legacy setup.py file (76 lines deleted) |
| pyproject.toml | Addition of comprehensive pyproject.toml configuration with all package metadata, dependencies, and build settings |
Copilot finished work on behalf of
swathipil
August 13, 2025 18:57
kashifkhan
reviewed
Aug 14, 2025
kashifkhan
reviewed
Aug 14, 2025
Co-authored-by: swathipil <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
swathipil
August 14, 2025 15:42
Copilot finished work on behalf of
swathipil
August 14, 2025 15:47
kashifkhan
approved these changes
Aug 14, 2025
l0lawrence
approved these changes
Aug 14, 2025
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
azure-messaging-webpubsubclientpackage from usingsetup.pyto the modernpyproject.tomlconfiguration format, following the Azure SDK Python guidelines and the pattern established by other Azure SDK packages.Changes Made
setup.pyto a comprehensivepyproject.tomlfileazure.messaging.webpubsubclient._version.VERSIONsetuptools>=77.0.3andwheeltests*,doc*,stress*,samples*,azure, andazure.messagingnamespace packagesaioextra) to the new formatKey Requirements Addressed
✅ Dynamic version file path: Correctly points to
azure.messaging.webpubsubclient._version.VERSION✅ Python version requirement: Updated to
>=3.9with support through Python 3.13✅ Repository URL: Set to
"https://github.com/Azure/azure-sdk-for-python"✅ py.typed setup: Configured as
pytyped = ["py.typed"]✅ Package exclusions: Comprehensive exclusions prevent unintended files from being included in the wheel distribution
The conversion follows the same pattern used by
azure-eventhuband other modernized Azure SDK packages. All metadata, dependencies, and build configuration have been preserved while moving to the standardized pyproject.toml format and updating Python version support.Fixes #42461.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.