-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[WebPubSubClient] Convert azure-messaging-webpubsubclient package from setup.py to pyproject.toml #42462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
5
commits into
main
Choose a base branch
from
copilot/fix-42461
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−76
Open
[WebPubSubClient] Convert azure-messaging-webpubsubclient package from setup.py to pyproject.toml #42462
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0464b09
Initial plan
Copilot 6bf28df
Convert azure-messaging-webpubsubclient from setup.py to pyproject.toml
Copilot 7fa70a9
Apply reviewer feedback: update repository URL, include CHANGELOG.md …
Copilot b80a5fa
Remove MIT License classifier from pyproject.toml as requested
Copilot 7b1b595
Add samples* to package exclusions in pyproject.toml
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
56 changes: 56 additions & 0 deletions
56
sdk/webpubsub/azure-messaging-webpubsubclient/pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,59 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=77.0.3", "wheel"] | ||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "azure-messaging-webpubsubclient" | ||
| authors = [ | ||
| {name = "Microsoft Corporation", email = "[email protected]"}, | ||
| ] | ||
| description = "Microsoft Azure Web PubSub Client Library for Python" | ||
| keywords = ["azure", "azure sdk"] | ||
| requires-python = ">=3.8" | ||
| license = "MIT" | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3 :: Only", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "License :: OSI Approved :: MIT License", | ||
swathipil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ] | ||
| dependencies = [ | ||
| "isodate>=0.6.1", | ||
| "azure-core>=1.26.3", | ||
| "websocket-client>=1.6.0", | ||
| ] | ||
| dynamic = ["version", "readme"] | ||
|
|
||
| [project.optional-dependencies] | ||
| aio = [ | ||
| "aiohttp>=3.9.3", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| repository = "https://github.com/Azure/azure-sdk-for-python" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The repository URL should end with '.git' according to Azure SDK guidelines. Change to 'https://github.com/Azure/azure-sdk-for-python.git' Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {attr = "azure.messaging.webpubsubclient._version.VERSION"} | ||
| readme = {file = ["README.md", "CHANGELOG.md"], content-type = "text/markdown"} | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| exclude = [ | ||
| "tests*", | ||
swathipil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "doc*", | ||
| "stress*", | ||
swathipil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "azure", | ||
| "azure.messaging", | ||
| ] | ||
|
|
||
| [tool.setuptools.package-data] | ||
| pytyped = ["py.typed"] | ||
|
|
||
| [tool.azure-sdk-build] | ||
| pylint = false | ||
| pyright = false | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license field should use the SPDX license identifier format. Change to 'license = {text = "MIT License"}' to match the original setup.py format and provide better license information.
Copilot uses AI. Check for mistakes.