Skip to content

fix: Save lock-token from receive_deferred_messages AMQP payload, into ServiceBusReceivedMessage #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,7 @@ def __init__(
self._settled = receive_mode == ServiceBusReceiveMode.RECEIVE_AND_DELETE
self._delivery_tag = self._amqp_transport.get_message_delivery_tag(message, frame)
self._delivery_id = self._amqp_transport.get_message_delivery_id(message, frame) # only used by pyamqp
self._received_lock_token = kwargs.get("lock_token", None)
self._received_timestamp_utc = utc_now()
self._is_deferred_message = kwargs.get("is_deferred_message", False)
self._is_peeked_message = kwargs.get("is_peeked_message", False)
Expand Down Expand Up @@ -1078,6 +1079,10 @@ def lock_token(self) -> Optional[Union[uuid.UUID, str]]:
if self._settled:
return None

if self._received_lock_token:
# this will already be a uuid.UUID
return self._received_lock_token

if self._delivery_tag:
return uuid.UUID(bytes_le=self._delivery_tag)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -818,15 +818,21 @@ def parse_received_message( # pylint:disable=docstring-keyword-should-match-keyw
:keyword ~azure.servicebus.ServiceBusReceiver receiver: Required.
:keyword bool is_peeked_message: Optional. For peeked messages.
:keyword bool is_deferred_message: Optional. For deferred messages.
:keyword uuid.UUID lock_token: Optional. Lock token, if it is given by the message receiver.
:keyword ~azure.servicebus.ServiceBusReceiveMode receive_mode: Optional.
:return: List of service bus received messages.
:rtype: list[~azure.servicebus.ServiceBusReceivedMessage]
"""
is_deferred_message = kwargs.get("is_deferred_message", False)
parsed = []
if message.value:
for m in message.value[b"messages"]:
wrapped = decode_payload(memoryview(m[b"message"]))
parsed.append(message_type(wrapped, **kwargs))
if is_deferred_message and b"lock-token" in m:
lock_token = m[b"lock-token"]
else:
lock_token = kwargs.pop("lock_token", None)
parsed.append(message_type(wrapped, lock_token=lock_token, **kwargs))
return parsed

@staticmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -863,14 +863,20 @@ def parse_received_message( # pylint:disable=docstring-keyword-should-match-keyw
:keyword ~azure.servicebus.ServiceBusReceiver receiver: Required.
:keyword bool is_peeked_message: Optional. For peeked messages.
:keyword bool is_deferred_message: Optional. For deferred messages.
:keyword uuid.UUID lock_token: Optional. Lock token, if it is given by the message receiver.
:keyword ~azure.servicebus.ServiceBusReceiveMode receive_mode: Optional.
:return: List of ServiceBusReceivedMessage.
:rtype: list[~azure.servicebus.ServiceBusReceivedMessage]
"""
is_deferred_message = kwargs.get("is_deferred_message", False)
parsed = []
for m in message.get_data()[b"messages"]:
wrapped = Message.decode_from_bytes(bytearray(m[b"message"]))
parsed.append(message_type(wrapped, **kwargs))
if is_deferred_message and b"lock-token" in m:
lock_token = m[b"lock-token"]
else:
lock_token = kwargs.pop("lock_token", None)
parsed.append(message_type(wrapped, lock_token=lock_token, **kwargs))
return parsed

@staticmethod
Expand Down
Loading