[AutoRelease] t2-servicefabricmanagedclusters-2025-08-12-53724(can only be merged by SDK owner) #42475
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request represents an automated release that updates the Azure Service Fabric Managed Clusters SDK from API version 2025-03-01-preview to 2025-06-01-preview. The changes include version bumps, new API features, and internal improvements to error handling and code generation.
- Updated API version from 2025-03-01-preview to 2025-06-01-preview
- Added new properties for outbound-only node types and service endpoint network identifiers
- Improved error handling with better deserialization patterns
Reviewed Changes
Copilot reviewed 94 out of 94 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump and Python 3.13 support |
| pyproject.toml | Moved packaging configuration from TOML |
| models/_models.py | Added new API properties and improved type annotations |
| operations/_operations.py | Updated API version strings and improved error handling |
| generated_tests/ | Updated test fixtures with new API properties |
| generated_samples/ | Updated API version references in sample files |
| @@ -1272,16 +1272,18 @@ class ClusterMonitoringPolicy(_Model): | |||
| """The amount of time that the application or cluster must remain healthy before the upgrade | |||
| proceeds to the next upgrade domain. The duration can be in either hh:mm:ss or in d.hh:mm:ss.ms | |||
| format. Required.""" | |||
| health_check_retry_timeout: str = rest_field( | |||
| health_check_retry_timeout: datetime.timedelta = rest_field( | |||
| name="healthCheckRetryTimeout", visibility=["read", "create", "update", "delete", "query"] | |||
| ) | |||
| """The amount of time to retry health evaluation when the application or cluster is unhealthy | |||
| before the upgrade rolls back. The timeout can be in either hh:mm:ss or in d.hh:mm:ss.ms | |||
| format. Required.""" | |||
There was a problem hiding this comment.
The type annotation change from 'str' to 'datetime.timedelta' for health_check_retry_timeout is a breaking change that could affect existing consumers who expect string values. This could cause runtime errors for users passing string values directly.
| format. Required.""" | |
| health_check_retry_timeout: Union[str, datetime.timedelta] = rest_field( | |
| name="healthCheckRetryTimeout", visibility=["read", "create", "update", "delete", "query"] | |
| ) | |
| """The amount of time to retry health evaluation when the application or cluster is unhealthy | |
| before the upgrade rolls back. The timeout can be in either hh:mm:ss or in d.hh:mm:ss.ms | |
| format. Required. Accepts either a string or a datetime.timedelta.""" |
Copilot uses AI. Check for mistakes.
| name="healthCheckRetryTimeout", visibility=["read", "create", "update", "delete", "query"] | ||
| ) | ||
| """The amount of time to retry health evaluation when the application or cluster is unhealthy | ||
| before the upgrade rolls back. The timeout can be in either hh:mm:ss or in d.hh:mm:ss.ms | ||
| format. Required.""" | ||
| upgrade_timeout: str = rest_field(name="upgradeTimeout", visibility=["read", "create", "update", "delete", "query"]) | ||
| upgrade_timeout: datetime.timedelta = rest_field( |
There was a problem hiding this comment.
The type annotation change from 'str' to 'datetime.timedelta' for upgrade_timeout is a breaking change that could affect existing consumers who expect string values. This could cause runtime errors for users passing string values directly.
Copilot uses AI. Check for mistakes.
| """The amount of time the overall upgrade has to complete before the upgrade rolls back. The | ||
| timeout can be in either hh:mm:ss or in d.hh:mm:ss.ms format. Required.""" | ||
| upgrade_domain_timeout: str = rest_field( | ||
| upgrade_domain_timeout: datetime.timedelta = rest_field( |
There was a problem hiding this comment.
The type annotation change from 'str' to 'datetime.timedelta' for upgrade_domain_timeout is a breaking change that could affect existing consumers who expect string values. This could cause runtime errors for users passing string values directly.
Copilot uses AI. Check for mistakes.
https://github.com/Azure/sdk-release-request/issues/6472
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=2422