Improve azure-ai-evaluation error message #42479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects an inaccurate error message in the azure-ai-evaluation SDK. The error message previously stated that only dictionaries are acceptable for the azure_ai_project parameter, but the code actually accepts both dictionaries and project URI strings.
Key Changes
- Updated error message to accurately reflect that both dictionaries and project URI strings are valid inputs
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/utils.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @mzat-msft! We will review the pull request and get back to you soon. |
Currently the error message mentions that only `dict` is an acceptable type for the parameter `azure_ai_project`. This is incorrect as also a `str` containing a project URI is acceptable.
mzat-msft
force-pushed
the
mzat-msft/eval-better-error
branch
from
3110da0 to
76388bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the error message mentions that only
dictis an acceptable type for the parameterazure_ai_project.This is incorrect as also a
strcontaining a project URI is acceptable.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines