Skip to content

Generate code for the activity step and add it to samples. #42492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nick863
Copy link
Member

@nick863 nick863 commented Aug 12, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 23:18
@nick863 nick863 changed the title Generate codefor the activity step and add it to samples. Generate code for the activity step and add it to samples. Aug 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Azure AI Agents SDK by regenerating code from a new API specification (commit hash updated from 511fb938 to 1197b127). The main purpose is to add support for the "activity step" functionality, which includes new models for MCP (Model Control Protocol) function parameters and run step activities. Additionally, the PR includes formatting fixes and parameter corrections across test files and samples.

Key Changes

  • Added new activity-related models (ActivityFunctionDefinition, ActivityFunctionParameters, FunctionArgument, RunStepActivityDetails, RunStepDetailsActivity) for MCP tool support
  • Updated error handling in operations to use HttpResponse objects instead of JSON directly
  • Applied code formatting fixes and trailing comma corrections across test files and samples

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsp-location.yaml Updated API spec commit hash reference
_models.py Added new activity and function parameter models for MCP support
_enums.py Added ACTIVITIES enum value to RunStepType
_operations.py Fixed error deserialization to use HttpResponse objects
model_base.py Updated failsafe deserialization functions to handle HttpResponse
test files Applied code formatting fixes and parameter corrections
sample files Applied formatting improvements and added activity step handling
CHANGELOG.md Added entry for new RunStepDetailsActivity feature

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

You probably want to use the sub-classes and not this class directly. Known sub-classes are:
RunStepMessageCreationDetails, RunStepToolCallDetails
class RunStepDetailsActivity(_Model):
"""Represents the list of activities, associated with the given step.*.
Copy link
Preview

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring has a stray asterisk and period at the end. It should be: "Represents the list of activities associated with the given step."

Suggested change
"""Represents the list of activities, associated with the given step.*.
"""Represents the list of activities associated with the given step.

Copilot uses AI. Check for mistakes.

Copy link

github-actions bot commented Aug 12, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-ai-agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant