-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[eng] deprecate "multiapi" - Remove multiapi functionality from eng folder #42866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: msyyc <[email protected]>
Co-authored-by: msyyc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated "multiapi" functionality from the Azure SDK for Python engineering tools and infrastructure. This includes deleting the multiapi combiner tool, templates, and all supporting code while simplifying the SDK generation pipeline to treat all packages consistently as single-API packages.
Key Changes
- Removes 958 lines of multiapi-specific code and templates
- Simplifies package generation logic to eliminate multiapi complexity
- Updates configuration files to remove multiapi options
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
multiapi_combiner.py |
Deleted entire 691-line multiapi code generation tool |
| Template files | Removed 9 Jinja2 template files for multiapi generation |
pyproject.toml |
Removed multiapi_combiner script entry point |
sdk_generator.py |
Removed multiapi detection and processing functions |
package_utils.py |
Simplified changelog generation by removing multiapi parameter |
| Configuration files | Removed multiapi options from test and config files |
changelog_generics.md |
Updated documentation to remove multiapi section |
|
@scbedd Need one approval from code owner to merge. Please help review this PR, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ code simplification. Love the cleanup efforts @msyyc !
|
/check-enforcer override |
This PR deprecates and removes all "multiapi" related code, tools, and documentation from the
engfolder as requested in the issue.Changes Made
Deleted Files (958 lines removed)
eng/tools/azure-sdk-tools/packaging_tools/multiapi_combiner.py- The main multiapi combiner tool (691 lines)eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/- Complete template directory with 9 Jinja2 template files for multiapi code generationModified Files
pyproject.toml- Removedmultiapi_combinerscript entry pointsdk_generator.py- Removed multiapi-specific functions:is_multiapi_package()- Function to detect multiapi packagesneed_regen_for_multiapi_package()- Function to handle multiapi regeneration logicisMultiapi=False)package_utils.py- Removedis_multiapiparameter fromchange_log_generate()function and simplified logictest_servicemetadata.py- Removed multiapi test referencechangelog_generics.md- Updated documentation to remove multiapi-specific sectionswagger_to_sdk_config_v4.json- Removed multiapi autorest configuration optionImpact
This change simplifies the SDK generation pipeline by:
The removal is backward-compatible as all packages will now be processed using the standard single-API generation path, which was already the recommended approach.
Fixes #42865.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.