Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 5, 2025

This PR deprecates and removes all "multiapi" related code, tools, and documentation from the eng folder as requested in the issue.

Changes Made

Deleted Files (958 lines removed)

  • eng/tools/azure-sdk-tools/packaging_tools/multiapi_combiner.py - The main multiapi combiner tool (691 lines)
  • eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/ - Complete template directory with 9 Jinja2 template files for multiapi code generation

Modified Files

  • pyproject.toml - Removed multiapi_combiner script entry point
  • sdk_generator.py - Removed multiapi-specific functions:
    • is_multiapi_package() - Function to detect multiapi packages
    • need_regen_for_multiapi_package() - Function to handle multiapi regeneration logic
    • Simplified package processing to treat all packages as single-api (isMultiapi=False)
    • Removed multiapi-specific conditional logic in sample cleanup
  • package_utils.py - Removed is_multiapi parameter from change_log_generate() function and simplified logic
  • test_servicemetadata.py - Removed multiapi test reference
  • changelog_generics.md - Updated documentation to remove multiapi-specific section
  • swagger_to_sdk_config_v4.json - Removed multiapi autorest configuration option

Impact

This change simplifies the SDK generation pipeline by:

  • Removing 958 lines of multiapi-specific code
  • Treating all packages consistently as single-API packages
  • Eliminating the complexity of multiapi template generation
  • Removing deprecated tooling while preserving all existing functionality for standard packages

The removal is backward-compatible as all packages will now be processed using the standard single-API generation path, which was already the recommended approach.

Fixes #42865.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] [eng] deprecate "multiapi" [eng] deprecate "multiapi" - Remove multiapi functionality from eng folder Sep 5, 2025
Copilot AI requested a review from msyyc September 5, 2025 08:42
Copilot finished work on behalf of msyyc September 5, 2025 08:42
@msyyc msyyc marked this pull request as ready for review September 8, 2025 08:24
Copilot AI review requested due to automatic review settings September 8, 2025 08:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated "multiapi" functionality from the Azure SDK for Python engineering tools and infrastructure. This includes deleting the multiapi combiner tool, templates, and all supporting code while simplifying the SDK generation pipeline to treat all packages consistently as single-API packages.

Key Changes

  • Removes 958 lines of multiapi-specific code and templates
  • Simplifies package generation logic to eliminate multiapi complexity
  • Updates configuration files to remove multiapi options

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
multiapi_combiner.py Deleted entire 691-line multiapi code generation tool
Template files Removed 9 Jinja2 template files for multiapi generation
pyproject.toml Removed multiapi_combiner script entry point
sdk_generator.py Removed multiapi detection and processing functions
package_utils.py Simplified changelog generation by removing multiapi parameter
Configuration files Removed multiapi options from test and config files
changelog_generics.md Updated documentation to remove multiapi section

@msyyc
Copy link
Member

msyyc commented Sep 9, 2025

@scbedd Need one approval from code owner to merge. Please help review this PR, thanks!

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ code simplification. Love the cleanup efforts @msyyc !

@msyyc msyyc closed this Nov 6, 2025
@msyyc msyyc deleted the copilot/fix-42865 branch November 6, 2025 02:31
@msyyc msyyc restored the copilot/fix-42865 branch November 6, 2025 02:32
@msyyc msyyc reopened this Nov 6, 2025
@msyyc
Copy link
Member

msyyc commented Nov 6, 2025

/check-enforcer override

@msyyc msyyc merged commit 0cea46d into main Nov 6, 2025
7 of 12 checks passed
@msyyc msyyc deleted the copilot/fix-42865 branch November 6, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[eng] deprecate "multiapi"

4 participants