-
Notifications
You must be signed in to change notification settings - Fork 3.2k
App Configuration Provider - Request tracing update #43589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors request tracing functionality by extracting it into a dedicated _RequestTracingContext class, improving code organization and maintainability. The changes add telemetry tracking for feature flag usage patterns (seed, telemetry, max variants) and detection for AI foundry package usage.
Key Changes
- Moved request tracing logic from
_azureappconfigurationproviderbase.pyto new_request_tracing_context.pyfile - Added tracking for feature flag usage patterns: seed usage, telemetry enablement, and max variants
- Added detection for
azure-ai-projectspackage to track AI usage - Updated all references from provider instance variables to
_tracing_contextproperties
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
_request_tracing_context.py |
New file containing extracted and enhanced request tracing logic with _RequestTracingContext class |
test_request_tracing_context.py |
Comprehensive test suite for the new _RequestTracingContext class |
_azureappconfigurationproviderbase.py |
Refactored to use _RequestTracingContext instance, removed duplicated tracing code |
test_azureappconfigurationproviderbase.py |
Updated tests to reflect refactored tracing context and removed obsolete test classes |
_azureappconfigurationprovider.py |
Updated to access feature filter usage through _tracing_context |
_azureappconfigurationproviderasync.py |
Updated async provider to access feature filter usage through _tracing_context |
test_provider.py |
Updated assertions to access AI configuration flags through _tracing_context |
test_async_provider.py |
Updated async test assertions to access AI configuration flags through _tracing_context |
_constants.py |
Added new constants for feature flag telemetry tags |
CHANGELOG.md |
Added entry for request tracing update |
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
.../azure-appconfiguration-provider/azure/appconfiguration/provider/_request_tracing_context.py
Outdated
Show resolved
Hide resolved
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
...configuration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py
Outdated
Show resolved
Hide resolved
…configuration/provider/_azureappconfigurationproviderbase.py Co-authored-by: Ross Grambo <[email protected]>
Description
azure-ai-foundryreturnsUSE_AIAll SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines