-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Remove fixedint #43659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fixedint #43659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the fixedint dependency from the azure-monitor-opentelemetry-exporter package by replacing it with manual 32-bit integer overflow handling. The key changes include:
- Removed
fixedintfrom runtime dependencies and moved it to dev requirements for testing purposes - Replaced
Int32type fromfixedintwith manual overflow logic in the DJB2 hash function - Renamed constants
_INTEGER_MAXand_INTEGER_MINto_INT32_MAXand_INT32_MINwith explicit value definitions - Added comprehensive test coverage for the
_get_DJB2_sample_scorefunction
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed fixedint from runtime install_requires dependencies |
| dev_requirements.txt | Added fixedint as a dev-only dependency for testing |
| _utils.py | Implemented manual 32-bit overflow handling to replace Int32 usage and renamed constants |
| _constants.py | Replaced fixedint.Int32 constants with explicit 32-bit integer boundary values |
| test_trace_utils.py | Added new comprehensive test suite for _get_DJB2_sample_score function |
| CHANGELOG.md | Updated changelog to document the removal of fixedint dependency |
...e-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_utils.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_trace_utils.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_trace_utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…/opentelemetry/exporter/export/trace/_utils.py Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Remove fixedint to reduce dependency footprint. This will help attach rate by limiting dependency overlap surface.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines