Skip to content

Conversation

@jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Oct 27, 2025

Description

Remove fixedint to reduce dependency footprint. This will help attach rate by limiting dependency overlap surface.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Oct 27, 2025
@jeremydvoss jeremydvoss marked this pull request as ready for review November 6, 2025 00:27
@jeremydvoss jeremydvoss requested a review from lzchen as a code owner November 6, 2025 00:27
Copilot AI review requested due to automatic review settings November 6, 2025 00:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the fixedint dependency from the azure-monitor-opentelemetry-exporter package by replacing it with manual 32-bit integer overflow handling. The key changes include:

  • Removed fixedint from runtime dependencies and moved it to dev requirements for testing purposes
  • Replaced Int32 type from fixedint with manual overflow logic in the DJB2 hash function
  • Renamed constants _INTEGER_MAX and _INTEGER_MIN to _INT32_MAX and _INT32_MIN with explicit value definitions
  • Added comprehensive test coverage for the _get_DJB2_sample_score function

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
setup.py Removed fixedint from runtime install_requires dependencies
dev_requirements.txt Added fixedint as a dev-only dependency for testing
_utils.py Implemented manual 32-bit overflow handling to replace Int32 usage and renamed constants
_constants.py Replaced fixedint.Int32 constants with explicit 32-bit integer boundary values
test_trace_utils.py Added new comprehensive test suite for _get_DJB2_sample_score function
CHANGELOG.md Updated changelog to document the removal of fixedint dependency

jeremydvoss and others added 2 commits November 6, 2025 10:50
…/opentelemetry/exporter/export/trace/_utils.py

Co-authored-by: Copilot <[email protected]>
Copy link
Member

@JacksonWeber JacksonWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremydvoss jeremydvoss merged commit e84b047 into Azure:main Nov 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants