Skip to content

Conversation

@lusu-msft
Copy link

@lusu-msft lusu-msft commented Nov 3, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 3, 2025 21:41
@github-actions github-actions bot added the AI label Nov 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the azure-ai-agentserver-core package, which provides an agent server adapter for Azure AI. The package enables building containerized custom agents with support for streaming responses, telemetry integration, and various agent frameworks.

Key changes:

  • New package with core server infrastructure (FoundryCBAgent, AgentRunContext)
  • Integration with Azure AI Projects models and OpenTelemetry tracing
  • Sample implementations including MCP tools integration and bilingual weekend planner
  • CI/CD configuration updates

Reviewed Changes

Copilot reviewed 67 out of 70 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/ai/ci.yml Adds CI configuration for the new package
pyproject.toml Package metadata and dependencies configuration
samples/* Example implementations showcasing package features
azure/ai/agentserver/core/* Core server, models, and logging infrastructure
eng/tox/run_sphinx_apidoc.py Fix for handling missing RST files

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-ai-agentserver-core

@scbedd
Copy link
Member

scbedd commented Nov 5, 2025

@lusu-msft I see what you're going for with the TEST_COMPATIBILITY_MAP to get this thing to build, followed by it crashing on the 39 tests. I've never actually run into this before, but I think the important thing is to ignore the compatibility of the package with the platform during build and analyze if we can. I'm going to work to get you unblocked by EoD.

@scbedd
Copy link
Member

scbedd commented Nov 5, 2025

Verifying my proposed fix in #43829 in #43830

@lusu-msft
Copy link
Author

Verifying my proposed fix in #43829 in #43830

thanks @scbedd. Then I should remove the compatibility override. right?

@scbedd
Copy link
Member

scbedd commented Nov 6, 2025

Verifying my proposed fix in #43829 in #43830

thanks @scbedd. Then I should remove the compatibility override. right?

Yes, you definitely will, but doing so right now will still be broken. I'm waiting on a review for my fix pr #43829 . Once that merges yep, you'll remove the TEST_COMPATIBILITY_MAP change and this PR will just start working. I'm quite confident because #43480 checks out! That's this PR + 43829 combined 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants