-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Howie/format memory #43819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Howie/format memory #43819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors test code to improve maintainability by consolidating duplicated client creation logic into helper methods and standardizing sanitized values to lowercase. The changes also include new test files for responses, conversations, files, and agent functionality, along with corresponding sample code and telemetry instrumentation tests.
Key Changes:
- Replaced inline
AIProjectClientinstantiation with centralizedcreate_client()andcreate_async_client()helper methods - Standardized sanitized API key values from
"Sanitized-api-key"to"sanitized-api-key" - Added comprehensive test coverage for new features including responses API, conversation CRUD operations, file operations, and agent functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_telemetry_async.py | Refactored to use create_async_client() helper and updated sanitized value casing |
| test_telemetry.py | Refactored to use create_client() helper and updated sanitized value casing |
| test_samples.py | Updated environment variable name in documentation comment |
| test_redteams_async.py | Removed redundant endpoint extraction and client creation code |
| test_redteams.py | Removed redundant endpoint extraction and client creation code |
| test_indexes_async.py | Removed redundant endpoint extraction and client creation code |
| test_indexes.py | Removed redundant endpoint extraction and client creation code |
| test_files_async.py | New comprehensive test file for async file operations |
| test_files.py | New comprehensive test file for sync file operations |
| test_deployments_async.py | Removed redundant endpoint extraction and client creation code |
| test_deployments.py | Removed redundant endpoint extraction and client creation code |
| test_datasets_async.py | Fixed test data folder path to use parent directory reference |
| test_datasets.py | Fixed test data folder path to use parent directory reference |
| test_connections_async.py | Removed redundant endpoint extraction and client creation code |
| test_connections.py | Removed unused import and redundant client creation code |
| conftest.py | Standardized sanitized values to lowercase for consistency |
| test_responses_async.py | New test file for async responses API functionality |
| test_responses.py | New test file for sync responses API with extensive documentation |
| test_hosted_agents.py | New placeholder test file for hosted agents functionality |
| test_conversation_items_crud_async.py | New test file for async conversation items CRUD operations |
| test_conversation_items_crud.py | New test file for sync conversation items CRUD operations |
| test_conversation_crud_async.py | New test file for async conversation CRUD operations |
| test_conversation_crud.py | New test file for sync conversation CRUD operations |
| test_container_app_agents_async.py | New test file for async container app agents |
| test_container_app_agents.py | New test file for sync container app agents |
| test_agents_crud_async.py | New test file for async agent CRUD operations |
| test_agents_crud.py | New test file for sync agent CRUD operations |
| test_agent_responses_crud_async.py | New test file for async agent responses CRUD operations |
| test_agent_responses_crud.py | New test file for sync agent responses CRUD operations |
| test_responses_instrumentor_metrics.py | New test file for responses instrumentor metrics validation |
| test_responses_instrumentor_async.py | New test file for async responses instrumentor tracing |
| test_responses_instrumentor.py | New comprehensive test file for responses instrumentor with multiple test scenarios |
| test_ai_instrumentor_base.py | New base class for AI instrumentor tests with shared utilities |
| test_ai_agents_instrumentor_async.py | New test file for async AI agents instrumentor |
| test_ai_agents_instrumentor.py | New test file for sync AI agents instrumentor |
| memory_trace_exporter.py | New utility class for in-memory trace export and validation |
| gen_ai_trace_verifier.py | New utility class for verifying GenAI trace attributes and events |
| Multiple sample files | Updated pip install commands to use versioned package specification and added new sample files for responses, files, agents with various tools (MCP, file search, image generation, web search, function tools) |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
19ba455
into
feature/azure-ai-projects/2.0.0b1
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines